From: Orit Wasserman <owasserm@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: pbonzini@redhat.com, quintela@redhat.com, chegu_vinod@hp.com,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte
Date: Thu, 21 Mar 2013 19:41:25 +0200 [thread overview]
Message-ID: <514B4645.4000100@redhat.com> (raw)
In-Reply-To: <514B4592.7030505@redhat.com>
On 03/21/2013 07:38 PM, Eric Blake wrote:
> On 03/21/2013 10:05 AM, Orit Wasserman wrote:
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> ---
>> savevm.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/savevm.c b/savevm.c
>> index baa45ae..686c8c8 100644
>> --- a/savevm.c
>> +++ b/savevm.c
>> @@ -647,6 +647,8 @@ void qemu_put_byte(QEMUFile *f, int v)
>>
>> f->buf[f->buf_index++] = v;
>> f->is_write = 1;
>> + f->bytes_xfer += 1;
>
> Why ' += 1' instead of the shorter '++'?
>
It compiles to the same code but I can change it :)
next prev parent reply other threads:[~2013-03-21 17:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 16:05 [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 1/9] Add QemuFileWritevBuffer QemuFileOps Orit Wasserman
2013-03-21 16:57 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function Orit Wasserman
2013-03-21 16:55 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte Orit Wasserman
2013-03-21 17:06 ` Juan Quintela
2013-03-21 17:38 ` Eric Blake
2013-03-21 17:41 ` Orit Wasserman [this message]
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 4/9] Store the data to send also in iovec Orit Wasserman
2013-03-21 17:11 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 5/9] Use writev ops if available Orit Wasserman
2013-03-21 17:17 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 6/9] More optimized qemu_put_be64/32/16 Orit Wasserman
2013-03-21 17:18 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 7/9] Add qemu_put_buffer_no_copy Orit Wasserman
2013-03-21 17:34 ` Juan Quintela
2013-03-21 17:39 ` Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 8/9] Use qemu_put_buffer_no_copy for guest memory pages Orit Wasserman
2013-03-21 16:14 ` Michael S. Tsirkin
2013-03-21 17:37 ` Juan Quintela
2013-03-21 18:08 ` Orit Wasserman
2013-03-21 18:21 ` Michael S. Tsirkin
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs Orit Wasserman
2013-03-21 16:16 ` Michael S. Tsirkin
2013-03-21 16:27 ` Orit Wasserman
2013-03-21 16:29 ` Michael S. Tsirkin
2013-03-21 16:40 ` Orit Wasserman
2013-03-21 17:10 ` Michael S. Tsirkin
2013-03-21 17:44 ` Juan Quintela
2013-03-21 17:46 ` Michael S. Tsirkin
2013-03-21 18:22 ` Juan Quintela
2013-03-21 18:33 ` Michael S. Tsirkin
2013-03-21 17:41 ` Juan Quintela
2013-03-21 17:12 ` [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Paolo Bonzini
2013-03-21 17:35 ` Orit Wasserman
2013-03-21 17:42 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B4645.4000100@redhat.com \
--to=owasserm@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=eblake@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).