From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjTX-0005V0-T7 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIjTP-00016r-II for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:40:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjTP-00016e-9Z for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:40:19 -0400 Message-ID: <514B4645.4000100@redhat.com> Date: Thu, 21 Mar 2013 19:41:25 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1363881940-27505-1-git-send-email-owasserm@redhat.com> <1363881940-27505-4-git-send-email-owasserm@redhat.com> <514B4592.7030505@redhat.com> In-Reply-To: <514B4592.7030505@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, quintela@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, mst@redhat.com On 03/21/2013 07:38 PM, Eric Blake wrote: > On 03/21/2013 10:05 AM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> savevm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/savevm.c b/savevm.c >> index baa45ae..686c8c8 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -647,6 +647,8 @@ void qemu_put_byte(QEMUFile *f, int v) >> >> f->buf[f->buf_index++] = v; >> f->is_write = 1; >> + f->bytes_xfer += 1; > > Why ' += 1' instead of the shorter '++'? > It compiles to the same code but I can change it :)