From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIk24-0006c9-KY for qemu-devel@nongnu.org; Thu, 21 Mar 2013 14:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIk22-0005o7-U8 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 14:16:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIk22-0005nv-K1 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 14:16:06 -0400 Message-ID: <514B4E62.8070002@redhat.com> Date: Thu, 21 Mar 2013 12:16:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363881457-14814-1-git-send-email-pl@kamp.de> <1363881457-14814-4-git-send-email-pl@kamp.de> In-Reply-To: <1363881457-14814-4-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QPHTHTCXKVBVGSMJOCBV" Subject: Re: [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations if possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QPHTHTCXKVBVGSMJOCBV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/21/2013 09:57 AM, Peter Lieven wrote: > performance gain on SSE2 is approx. 20-25%. altivec > is not tested. performance for unsigned long arithmetic > is unchanged. >=20 > Signed-off-by: Peter Lieven > --- > util/cutils.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/util/cutils.c b/util/cutils.c > index 6d079ac..52205a2 100644 > --- a/util/cutils.c > +++ b/util/cutils.c > @@ -210,6 +210,11 @@ bool buffer_is_zero(const void *buf, size_t len) > long d0, d1, d2, d3; > const long * const data =3D buf; > =20 > + /* use vector optimized zero check if possible */ > + if (can_use_buffer_find_nonzero_offset(buf,len)) { Space after comma. > + return buffer_find_nonzero_offset(buf, len)=3D=3Dlen; And still missing spaces around the '=3D=3D', even though I pointed it ou= t in v2. Run your series through checkpatch.pl. As whitespace cleanups are trivial, you can send v4 with: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QPHTHTCXKVBVGSMJOCBV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRS05iAAoJEKeha0olJ0NqFHwH/0UvmuThKEYlwLtPM5IVJMve 9apcrX64dhoSZI161ETiGBpr+mf0N9HCc8w7IbgxDYBvg/JK5WEtNUw1+okAgI6o ClwOANpR10uxS33oiIKrXQSKANG2xYwFSL//bOUxvwwWd+1qO+XdKxuUVm90+YSY Z/cLiCfALZkyKvvja6zurHB1MSUM/UhBWrmLqClVt3lafcEq54QNOeSunX1W58ZJ vCkD3GTAKPqqS23ZlE0SLd2N6U/bI7S4a8qtOYNafZt5GA97/fnVDGJMgV/Eun4T DSvuLBLtOu3e5qlG6WCqtGrhQNTuApjYaOa5RQfT8jhjn8aTakTqo2zYAUyNHEI= =UBKo -----END PGP SIGNATURE----- ------enig2QPHTHTCXKVBVGSMJOCBV--