qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Alexandre Kandalintsev <spam@messir.net>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ifname=xxx for -netdev bridge
Date: Thu, 21 Mar 2013 12:57:20 -0600	[thread overview]
Message-ID: <514B5810.7080905@redhat.com> (raw)
In-Reply-To: <20130321190509.6e1d73e5@messir.net>

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On 03/21/2013 12:05 PM, Alexandre Kandalintsev wrote:
> Hi!
> 
> 
> Here is the patch that allows us to specify the name of tap interface
> when -netdev bridge is used. It's like -netdev tap,ifname=xxx, but for
> bridges.
> 

> +++ b/qapi-schema.json
> @@ -2676,6 +2676,7 @@
>  { 'type': 'NetdevBridgeOptions',
>    'data': {
>      '*br':     'str',
> +    '*ifname': 'str',
>      '*helper': 'str' } }

You also need to add a line documenting this field:

# @ifname: #optional Set the interface name that will be used (since 1.5).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-03-21 18:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 18:05 [Qemu-devel] [PATCH] ifname=xxx for -netdev bridge Alexandre Kandalintsev
2013-03-21 18:57 ` Eric Blake [this message]
2013-03-24 13:17   ` [Qemu-devel] [PATCH v2] " Alexandre Kandalintsev
2013-03-25  9:03 ` [Qemu-devel] [PATCH] " Stefan Hajnoczi
2013-03-25 21:28   ` Alexandre Kandalintsev
2014-01-14 18:39     ` William Dauchy
2014-01-20 21:23       ` Alexandre Kandalintsev
2014-01-23 14:30         ` William Dauchy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B5810.7080905@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spam@messir.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).