From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIlCw-0001LL-5Q for qemu-devel@nongnu.org; Thu, 21 Mar 2013 15:31:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIlCu-0000RJ-Kl for qemu-devel@nongnu.org; Thu, 21 Mar 2013 15:31:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIlCu-0000Qt-CD for qemu-devel@nongnu.org; Thu, 21 Mar 2013 15:31:24 -0400 Message-ID: <514B6006.2010904@redhat.com> Date: Thu, 21 Mar 2013 13:31:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363881457-14814-1-git-send-email-pl@kamp.de> <1363881457-14814-10-git-send-email-pl@kamp.de> In-Reply-To: <1363881457-14814-10-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2RSKXFWTKPXXPBFILUQXL" Subject: Re: [Qemu-devel] [PATCHv3 9/9] migration: use XBZRLE only after bulk stage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RSKXFWTKPXXPBFILUQXL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/21/2013 09:57 AM, Peter Lieven wrote: > at the beginning of migration all pages are marked dirty and > in the first round a bulk migration of all pages is performed. >=20 > currently all these pages are copied to the page cache regardless > if there are frequently updated or not. this doesn't make sense s/if there/of whether they/ > since most of these pages are never transferred again. >=20 > this patch changes the XBZRLE transfer to only be used after > the bulk stage has been completed. that means a page is added > to the page cache the second time it is transferred and XBZRLE > can benefit from the third time of transfer. >=20 > since the page cache is likely smaller than the number of pages > its also likely that in the second round the page is missing in the s/its/it's/ > cache due to collisions in the bulk phase. >=20 > on the other hand a lot of unnecessary mallocs, memdups and frees > are saved. >=20 =2E.. > Signed-off-by: Peter Lieven > --- > arch_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Prior review still stands (touching up typos in a commit message generally does not invalidate carrying forward a reviewed-by comment). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2RSKXFWTKPXXPBFILUQXL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRS2AGAAoJEKeha0olJ0NqVWIH/Ru5xg+AvrhwjEl4hpAoOTdE 4zNoPi3j0xW7x/T5fZ4G07T2sANkzBh+I0shL0mnsGv/RmbQNaHKSeDrRzlrCeRq vZg60QAycf3napMmFERe2KWS4+zf3qzp03Sq89xVHnz5wp/hc0JGxLKaBJG7bDLg 6l9ltG6/BNNEE7ACBXhvueL95eY/aNrXtH4wGqIpYv8ylZ3VIlCG0VMUMQ66Ez2D RCKx3WkgQKLMnmye3uQ8U4RfrBgNxwNqcRuRzqrm/oB8zAU7LTDmju0gJb1r2W8q NUrRw6EwraQ14HokT+sPXQPC0TXz3Xj0BjUSDF81yO9i0RW+95Zxwj5xfjSl5Ww= =YT42 -----END PGP SIGNATURE----- ------enig2RSKXFWTKPXXPBFILUQXL--