From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UImJN-0000nc-1W for qemu-devel@nongnu.org; Thu, 21 Mar 2013 16:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UImJG-00086n-KD for qemu-devel@nongnu.org; Thu, 21 Mar 2013 16:42:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UImJG-00086a-Cf for qemu-devel@nongnu.org; Thu, 21 Mar 2013 16:42:02 -0400 Message-ID: <514B7119.2030409@redhat.com> Date: Thu, 21 Mar 2013 21:44:09 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1363283360-26220-1-git-send-email-armbru@redhat.com> <1363283360-26220-5-git-send-email-armbru@redhat.com> In-Reply-To: <1363283360-26220-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qjson: to_json() case QTYPE_QSTRING is buggy, rewrite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org On 03/14/13 18:49, Markus Armbruster wrote: > Known bugs in to_json(): > My rewrite fixes them as follows: I'll try to review this sometime later. Patch review doesn't scale *at all*. I've spent hours on the first 3 patches. You should just be given pull req rights. I'd need 36 hour days. /me throws his hands up Laszlo