From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UJfwo-00073i-UD
	for qemu-devel@nongnu.org; Sun, 24 Mar 2013 04:06:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UJfwn-0004px-Ri
	for qemu-devel@nongnu.org; Sun, 24 Mar 2013 04:06:34 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:47400)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UJfwn-0004pt-LL
	for qemu-devel@nongnu.org; Sun, 24 Mar 2013 04:06:33 -0400
Message-ID: <514EB406.7080207@weilnetz.de>
Date: Sun, 24 Mar 2013 09:06:30 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1364110875-7074-1-git-send-email-namei.unix@gmail.com>
In-Reply-To: <1364110875-7074-1-git-send-email-namei.unix@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] rbd: fix compile error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 24.03.2013 08:41, schrieb Liu Yuan:
> From: Liu Yuan <tailai.ly@taobao.com>
>
> Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes] didn't
> update rbd.c accordingly.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
>  block/rbd.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 8cd10a7..1a8ea6d 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -441,7 +441,8 @@ static int qemu_rbd_aio_flush_cb(void *opaque)
>      return (s->qemu_aio_count > 0);
>  }
>  
> -static int qemu_rbd_open(BlockDriverState *bs, const char *filename, int flags)
> +static int qemu_rbd_open(BlockDriverState *bs, const char *filename,
> +                         QDict *options, int flags)
>  {
>      BDRVRBDState *s = bs->opaque;
>      char pool[RBD_MAX_POOL_NAME_SIZE];


Reviewed-by: Stefan Weil <sw@weilnetz.de>