From: "Andreas Färber" <afaerber@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output
Date: Sun, 24 Mar 2013 18:38:22 +0100 [thread overview]
Message-ID: <514F3A0E.8080800@suse.de> (raw)
In-Reply-To: <512DD3C5.10100@siemens.com>
Am 27.02.2013 10:37, schrieb Jan Kiszka:
> On 2013-02-27 10:33, Andreas Färber wrote:
>> Am 27.02.2013 10:15, schrieb Jan Kiszka:
>>> Several issues fixed:
>>> - We were missing a bunch of feature lists. Fix this by simply dumping
>>> the meta list feature_word_info.
>>> - kvm_enabled() cannot be true at this point because accelerators are
>>> initialized much later during init. Also, hiding this makes it very
>>> hard to discover for users. Simply dump unconditionally if CONFIG_KVM
>>> is set.
>>> - Add explanation for "host" CPU type.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>
>>> Changes in v2:
>>> - Do not dump "host" type if CONFIG_KVM is not set
>>> - Explain that "host" depends on KVM mode
>>
>> I had requested on v1 to not fix multiple issues in one patch, but I can
>> split it myself on Friday if there's no other issues.
>
> Sorry, missed that. But I also see no point in splitting up in this
> case, specifically as we no agree on the result.
Thanks, applied to qom-cpu as two patches (clean git-checkout -p split):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Sorry for taking so long.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
parent reply other threads:[~2013-03-24 17:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <512DD3C5.10100@siemens.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514F3A0E.8080800@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).