From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJpJP-0005ZG-4p for qemu-devel@nongnu.org; Sun, 24 Mar 2013 14:06:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJpJN-0004C2-UR for qemu-devel@nongnu.org; Sun, 24 Mar 2013 14:06:31 -0400 Received: from mout.web.de ([212.227.17.12]:55410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJpJN-0004Bw-Jh for qemu-devel@nongnu.org; Sun, 24 Mar 2013 14:06:29 -0400 Message-ID: <514F40A2.6000202@web.de> Date: Sun, 24 Mar 2013 19:06:26 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1361367806-4599-1-git-send-email-aliguori@us.ibm.com> <1361367806-4599-10-git-send-email-aliguori@us.ibm.com> <5127B788.40701@siemens.com> <5127BBC1.5070607@siemens.com> <512B7B8B.1000402@siemens.com> <87zjys9zcv.fsf@codemonkey.ws> <512B86E7.80603@siemens.com> In-Reply-To: <512B86E7.80603@siemens.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2TTIKAABKLPVIVPRGUGBN" Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anthony Liguori , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TTIKAABKLPVIVPRGUGBN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-02-25 16:44, Jan Kiszka wrote: > On 2013-02-25 16:39, Anthony Liguori wrote: >> Jan Kiszka writes: >> >>> This is in fact very simply: When the input in grabbed, everything >>> should be exclusively passed to the guest - except it has our magic >>> CTRL-ALT modifier set. Then let GTK filter out those accels that are = in >>> use. When checking the modifier state, we just need to filter out NUM= >>> and CAPS lock. >> >> Can you explain what you're fixing? >=20 > That it's not filtering what it is supposed to. >=20 >> >> We shouldn't hard code modifiers like this. The reason you give >> accelerators paths like this is so that they can be overridden by a >> user. >> >> That's why I filtered by path. Once we're running, we shouldn't assum= e >> that accelerators use the modifiers we started with. >=20 > Your path-based filtering does not work as it uses an unsupported > internal function (see my other mail). >=20 > We can make the modifier configurable via QEMU means (command line > parameter, gconfig, whatever). But let's get the basics working first. The bug still exists, my patch still applies. Unless you have some idea for a better solution, please apply this for now so that CTRL-q inside a guest doesn't kill more kittens. Jan ------enig2TTIKAABKLPVIVPRGUGBN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlFPQKIACgkQitSsb3rl5xRjZgCg6+m6l0MH1U7YrWImkY4w3ESg XEkAn3mx9Hl9EZp24wIpil2Dj8unsG6m =2n+L -----END PGP SIGNATURE----- ------enig2TTIKAABKLPVIVPRGUGBN--