From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UK2GF-0004ba-Dc
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 03:56:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UK2G8-0000Ri-Ok
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 03:56:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UK2G8-0000Rb-HX
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 03:56:00 -0400
Message-ID: <51500302.6040506@redhat.com>
Date: Mon, 25 Mar 2013 08:55:46 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1363084369-27517-1-git-send-email-kraxel@redhat.com>
	<1363084369-27517-17-git-send-email-kraxel@redhat.com>
	<515001C2.7080201@web.de>
In-Reply-To: <515001C2.7080201@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in
 gfx hardware emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, X86 <xen-devel@lists.xensource.com>, Igor Mitsyanko <i.mitsyanko@samsung.com>, Evgeny Voevodin <e.voevodin@samsung.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org, Dmitry Solodkiy <d.solodkiy@samsung.com>, Maksim Kozlov <m.kozlov@samsung.com>

On 03/25/13 08:50, Jan Kiszka wrote:
> On 2013-03-12 11:32, Gerd Hoffmann wrote:
>> Use QemuConsole instead.  Updates interfaces in console.[ch] and
>> adapts gfx hardware emulation code.
> 
> Breaks vmware-vga, the X server no longer starts up.
> 
> I do not spot any obvious typo etc. in the conversion, so I
> suspect, some values returned by the surface API differ from those
> that the DisplayState used to provide.
> 
> Jan

Known issue, fix is queued but not yet merged:

http://patchwork.ozlabs.org/patch/229214/

cheers,
  Gerd