From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK9DK-0002I3-55 for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK9DH-00006K-2G for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:21:34 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:49303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK9DG-00005j-Uq for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:21:30 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Mar 2013 11:21:28 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DC977C90029 for ; Mon, 25 Mar 2013 11:21:22 -0400 (EDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2PFLMBc26935446 for ; Mon, 25 Mar 2013 11:21:22 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2PFIa5Y003963 for ; Mon, 25 Mar 2013 09:18:37 -0600 Message-ID: <51506ACB.1090506@linux.vnet.ibm.com> Date: Mon, 25 Mar 2013 11:18:35 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1785134388.13096135.1364216711974.JavaMail.root@redhat.com> In-Reply-To: <1785134388.13096135.1364216711974.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Orit Wasserman , quintela@redhat.com, chegu vinod , qemu-devel@nongnu.org, mst@redhat.com Right, the header's not used - but, are we certain that put_buffer_copy() will *always* be used for RAM in the future? - Michael On 03/25/2013 09:05 AM, Paolo Bonzini wrote: > > ----- Messaggio originale ----- >> Da: "Michael R. Hines" >> A: "Orit Wasserman" >> Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com, "chegu vinod" , >> quintela@redhat.com >> Inviato: Sabato, 23 marzo 2013 17:27:49 >> Oggetto: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy >> >> Can you add a "flag" or something to indicate that the iov pointer >> belongs to RAM and not to device state? >> >> That way, I could re-use this code for RDMA - if I see this flag, I >> will know to send to RDMA..... > I am not sure you can, because the function will be preceded by > a qemu_put_be64 to store the header. That header is not sent in > the RDMA case, isn't it? > > Paolo >