From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKAEL-0006ME-Uf for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKABr-0005C2-MT for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:24:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKABr-0005Bp-CY for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:24:07 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2PGO65s023331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Mar 2013 12:24:06 -0400 Message-ID: <51507A22.2050101@redhat.com> Date: Mon, 25 Mar 2013 17:24:02 +0100 From: Michal Novotny MIME-Version: 1.0 References: <5641e296349cc434c7c03e4f51567c4210f9e426.1364212676.git.minovotn@redhat.com> <20130325121327.0aef9200@redhat.com> In-Reply-To: <20130325121327.0aef9200@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP command cpu_max List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 03/25/2013 05:13 PM, Luiz Capitulino wrote: > On Mon, 25 Mar 2013 16:58:50 +0100 > Michal Novotny wrote: > >> These commands return the maximum number of CPUs supported by the > /These commands/This command I meant both of them - both QMP (query-cpu-max) one HMP (cpu_max) one. > >> currently running emulator instance, as defined in its QEMUMachine >> struct. >> >> Signed-off-by: Michal Novotny >> --- >> hmp-commands.hx | 14 ++++++++++++++ >> hmp.c | 15 +++++++++++++++ >> hmp.h | 1 + >> qapi-schema.json | 11 +++++++++++ >> qmp-commands.hx | 22 ++++++++++++++++++++++ >> vl.c | 5 +++++ >> 6 files changed, 68 insertions(+) >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index df44906..c976459 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -690,6 +690,20 @@ Set the default CPU. >> ETEXI >> >> { >> + .name = "cpu_max", >> + .args_type = "", >> + .params = "", >> + .help = "Get maximum number of VCPUs supported by machine", >> + .mhandler.cmd = hmp_query_cpu_max, >> + }, >> + >> +STEXI >> +@item cpu_max >> +@findex cpu_max >> +Returns the number of CPUs supported by the machine being emulated. >> +ETEXI >> + >> + { >> .name = "mouse_move", >> .args_type = "dx_str:s,dy_str:s,dz_str:s?", >> .params = "dx dy [dz]", >> diff --git a/hmp.c b/hmp.c >> index b0a861c..6d5674f 100644 >> --- a/hmp.c >> +++ b/hmp.c >> @@ -748,6 +748,21 @@ void hmp_ringbuf_read(Monitor *mon, const QDict *qdict) >> g_free(data); >> } >> >> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict) >> +{ >> + int cpu_max; >> + Error *errp = NULL; >> + >> + cpu_max = qmp_query_cpu_max(&errp); >> + if (errp) { >> + monitor_printf(mon, "%s\n", error_get_pretty(errp)); >> + error_free(errp); >> + return; >> + } > Sorry for not noticing this before, but you can pass NULL to > qmp_query_cpu_max(), as it never fails. Ok, I just went according to the docs and there was no mention about it's possible to pass NULL. I don't know what magic qemu does with that one so I rather don't pass NULL. However, respin necessary? Michal -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org