From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UKAJU-000357-LR
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:32:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UKAJP-0008Gf-U7
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:32:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UKAJP-0008GY-Lp
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:31:55 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2PGVs68026726
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Mar 2013 12:31:55 -0400
Message-ID: <51507BF9.2060203@redhat.com>
Date: Mon, 25 Mar 2013 17:31:53 +0100
From: Michal Novotny <minovotn@redhat.com>
MIME-Version: 1.0
References: <5641e296349cc434c7c03e4f51567c4210f9e426.1364212676.git.minovotn@redhat.com>
	<20130325121327.0aef9200@redhat.com> <51507A22.2050101@redhat.com>
	<20130325122705.252ec622@redhat.com>
In-Reply-To: <20130325122705.252ec622@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP
	command cpu_max
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Version 3 sent to both you and list.

Michal

On 03/25/2013 05:27 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 17:24:02 +0100
> Michal Novotny <minovotn@redhat.com> wrote:
>
>>>> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
>>>> +{
>>>> +    int cpu_max;
>>>> +    Error *errp = NULL;
>>>> +
>>>> +    cpu_max = qmp_query_cpu_max(&errp);
>>>> +    if (errp) {
>>>> +        monitor_printf(mon, "%s\n", error_get_pretty(errp));
>>>> +        error_free(errp);
>>>> +        return;
>>>> +    }
>>> Sorry for not noticing this before, but you can pass NULL to
>>> qmp_query_cpu_max(), as it never fails.
>>
>> Ok, I just went according to the docs and there was no mention about
>> it's possible to pass NULL. I don't know what magic qemu does with that
>> one so I rather don't pass NULL. However, respin necessary?
> If you look in hmp.c you'll see examples of this. Please respin, otherwise
> we'll be committing code that is never used.

-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org