From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKCe8-0005Cz-El for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKCdx-0002X0-BJ for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:01:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKCdx-0002Wm-08 for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:01:17 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2PJ1GCw020310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Mar 2013 15:01:16 -0400 Message-ID: <51509EF8.1030101@redhat.com> Date: Mon, 25 Mar 2013 13:01:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364232620-5293-1-git-send-email-kwolf@redhat.com> <1364232620-5293-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1364232620-5293-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AHOJWXFLDOVXIQSMCPAV" Subject: Re: [Qemu-devel] [PATCH 02/19] qcow2: Remove bogus unlock of s->lock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AHOJWXFLDOVXIQSMCPAV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/25/2013 11:30 AM, Kevin Wolf wrote: > The unlock wakes up the next coroutine, but the currently running > coroutine will lock it again before it yields, so this doesn't make a > lot of sense. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 -- > 1 file changed, 2 deletions(-) Code matches the commit message, but my familiarity with coroutines is too weak to give a strong review. >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index 8ea696a..3f7edf5 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriver= State *bs, > QLIST_REMOVE(l2meta, next_in_flight); > } > =20 > - qemu_co_mutex_unlock(&s->lock); > qemu_co_queue_restart_all(&l2meta->dependent_requests); > - qemu_co_mutex_lock(&s->lock); > =20 > g_free(l2meta); > l2meta =3D NULL; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AHOJWXFLDOVXIQSMCPAV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUJ75AAoJEKeha0olJ0NqBUcH/1ojhCRaKMZiX6/b0l6T7tnL jCcJoq4O7B/1qidL8O5QqBSD9yMWv7peSp5ci+H8znV92Y6mngi+nklAhXzHdt4G 4ErqIjjCh10cR+fs2xiaXs0JUz0q5rAMT22dqN3IeomtOvt+qJKJVulKZdvACxq7 wE0tiXLtDnLmrptvmjtQPG+QBWwCJb2E4GRDlWk1aZrOPiI4J9GeBg1V5gYM2lEy WhesvAveEZaEEhAMC3BsSZhq+T6Gd7xTSz5zUIjBNKl5hau7OgXfOXaVNul2K/LJ qwUeNL2vjVhS7CSfUtXw1Ylr6XtuljFFwRPxydlUQuyR+Wu3dOzCLZKpiBtpRD0= =Qz8k -----END PGP SIGNATURE----- ------enig2AHOJWXFLDOVXIQSMCPAV--