From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKERr-0008Nf-6O for qemu-devel@nongnu.org; Mon, 25 Mar 2013 16:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKERq-0002ZH-5N for qemu-devel@nongnu.org; Mon, 25 Mar 2013 16:56:55 -0400 Received: from terminus.zytor.com ([2001:1868:205::10]:48341 helo=mail.zytor.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKERp-0002Z3-Rc for qemu-devel@nongnu.org; Mon, 25 Mar 2013 16:56:54 -0400 Message-ID: <5150BA09.7070809@zytor.com> Date: Mon, 25 Mar 2013 13:56:41 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 References: <1362017554-1260-1-git-send-email-hpa@zytor.com> <51501B58.1060300@suse.de> <20130325161515.06a2970b@nial.usersys.redhat.com> <51509B0E.40804@zytor.com> <20130325190537.GH8494@otherpad.lan.raisama.net> <5150B77B.7060207@zytor.com> <20130325205636.GK8494@otherpad.lan.raisama.net> In-Reply-To: <20130325205636.GK8494@otherpad.lan.raisama.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , Orit Wasserman , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Anthony Liguori , qemu-devel@nongnu.org On 03/25/2013 01:56 PM, Eduardo Habkost wrote: > >> >> It needs to be possible to fix bugs.... > > It is possible to fix them today: just write a compat function or add a > global variable that is handled by cpu_x86_init(), and call it from the > pc-1.3 machine-type init function. See disable_kvm_pv_eoi() and > enable_compat_apic_id_mode(), for example. > > The difference is that this will be much easier once we introduce the > static properties: then you just need to add the compat property values > to the compat_props field on the machine-type struct. > It sounds like this is underway, and since the priority for the 486 bit is very low it is better for that bit to just wait. -hpa