From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UKOh0-0002sg-Je
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 03:53:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UKOgy-0006m6-R9
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 03:53:14 -0400
Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:61435)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UKOgy-0006lt-LC
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 03:53:12 -0400
Received: by mail-ea0-f180.google.com with SMTP id d10so827219eaj.39
	for <qemu-devel@nongnu.org>; Tue, 26 Mar 2013 00:53:11 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <515153DF.9070805@redhat.com>
Date: Tue, 26 Mar 2013 08:53:03 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1363847789.git.hutao@cn.fujitsu.com>
	<1363856914-23399-2-git-send-email-hutao@cn.fujitsu.com>
	<514ACEDA.8080506@redhat.com>
	<20130321091711.GB21556@localhost.localdomain>
	<20130322074818.GM9382@redhat.com>
	<20130326015952.GC27169@localhost.localdomain>
	<5151482D.8040004@redhat.com>
	<20130326072443.GA2539@localhost.localdomain>
In-Reply-To: <20130326072443.GA2539@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in
	pvpanic ioport
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jones <drjones@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Alex Williamson <alex.williamson@redhat.com>, Juan Quintela <quintela@redhat.com>, Gleb Natapov <gleb@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, Alexander Graf <agraf@suse.de>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Il 26/03/2013 08:24, Hu Tao ha scritto:
>>> > > ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest,
>>> > > one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should
>>> > > use the one in q35-acpi-dsdt.hex to patch DSDT for q35. But including
>>> > > q35-acpi-dsdt.hex, along with acpi-dsdt.hex, will result in redefinition
>>> > > of dsdt_isa_pest. I didn't see a simple way to solve this.
>> > 
>> > Compile it in a separate file and include it in the SSDT (build_ssdt in
>> > src/acpi.c).
> Doesn't work. iasl gives an error:
> 
> Data Table Compiler is not available yet
> 
> Even though it compiles, I think the generated offset (*dsdt_isa_pest)
> won't be correct because it depends on acpi-dsdt.dsl/q35-acpi-dsdt.dsl.

See how it is done for ssdt-misc.aml (in fact, you can simply extend
ssdt-misc.aml).

Paolo