qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin O'Connor <kevin@koconnor.net>,
	seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v15.1] Add pvpanic device driver
Date: Tue, 26 Mar 2013 10:08:55 +0100	[thread overview]
Message-ID: <515165A7.4020801@redhat.com> (raw)
In-Reply-To: <1364287937-19684-1-git-send-email-hutao@cn.fujitsu.com>

Il 26/03/2013 09:52, Hu Tao ha scritto:
> pvpanic device is used to notify host(qemu) when guest panic happens.
> 
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> 
> Paolo,
> 
> Can I add your Signed-off-by? Since the original code is given by you.

Sure, as you prefer.

Paolo

>  src/acpi.c        |  3 +++
>  src/ssdt-misc.dsl | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
> 
> diff --git a/src/acpi.c b/src/acpi.c
> index bc4d8ea..fe504f0 100644
> --- a/src/acpi.c
> +++ b/src/acpi.c
> @@ -534,6 +534,9 @@ build_ssdt(void)
>          ssdt_ptr[acpi_pci64_valid[0]] = 0;
>      }
>  
> +    int pvpanic_port = romfile_loadint("etc/pvpanic-port", 0x0);
> +    *(u16 *)(ssdt_ptr + *ssdt_isa_pest) = pvpanic_port;
> +
>      ssdt_ptr += sizeof(ssdp_misc_aml);
>  
>      // build Scope(_SB_) header
> diff --git a/src/ssdt-misc.dsl b/src/ssdt-misc.dsl
> index 679422b..acc850e 100644
> --- a/src/ssdt-misc.dsl
> +++ b/src/ssdt-misc.dsl
> @@ -55,4 +55,50 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
>              Zero   /* reserved */
>          })
>      }
> +
> +    External(\_SB.PCI0, DeviceObj)
> +    External(\_SB.PCI0.ISA, DeviceObj)
> +
> +    Scope(\_SB.PCI0.ISA) {
> +        Device(PEVT) {
> +            Name(_HID, "QEMU0001")
> +            /* PEST will be patched to be Zero if no such device */
> +            ACPI_EXTRACT_NAME_WORD_CONST ssdt_isa_pest
> +            Name(PEST, 0xFFFF)
> +            OperationRegion(PEOR, SystemIO, PEST, 0x01)
> +            Field(PEOR, ByteAcc, NoLock, Preserve) {
> +                PEPT,   8,
> +            }
> +
> +            Method(_STA, 0, NotSerialized) {
> +                Store(PEST, Local0)
> +                If (LEqual(Local0, Zero)) {
> +                    Return (0x00)
> +                } Else {
> +                    Return (0x0F)
> +                }
> +            }
> +
> +            Method(RDPT, 0, NotSerialized) {
> +                Store(PEPT, Local0)
> +                Return (Local0)
> +            }
> +
> +            Method(WRPT, 1, NotSerialized) {
> +                Store(Arg0, PEPT)
> +            }
> +
> +            Name(_CRS, ResourceTemplate() {
> +                IO(Decode16, 0x00, 0x00, 0x01, 0x01, IO)
> +            })
> +
> +            CreateWordField(_CRS, IO._MIN, IOMN)
> +            CreateWordField(_CRS, IO._MAX, IOMX)
> +
> +            Method(_INI, 0, NotSerialized) {
> +                Store(PEST, IOMN)
> +                Store(PEST, IOMX)
> +            }
> +        }
> +    }
>  }
> 

  reply	other threads:[~2013-03-26  9:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  8:35 [Qemu-devel] [PATCH v15 0/6] Add pvpanic device to deal with guest panic event Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [PATCH v15 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [PATCH v15 2/6] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [PATCH v15 3/6] introduce a new qom device to deal with panicked event Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [PATCH v15 4/6] pvpanic: add document of pvpanic Hu Tao
2013-03-21  9:13   ` Paolo Bonzini
2013-03-22  7:15     ` Hu Tao
2013-03-26  3:03     ` [Qemu-devel] [PATCH v15.1 " Hu Tao
2013-03-26  9:21       ` Paolo Bonzini
2013-03-26 15:07       ` Eric Blake
2013-03-28  6:16         ` [Qemu-devel] [PATCH v15.2 " Hu Tao
2013-03-28 12:16           ` Eric Blake
2013-03-28 14:57             ` Paolo Bonzini
2013-03-29  7:15               ` Hu Tao
2013-03-29  7:12             ` Hu Tao
2013-03-22  1:59   ` [Qemu-devel] [PATCH v15 " Eric Blake
2013-03-22  7:15     ` Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [RFC][PATCH v15 5/6] pc_piix, pc_q35: export fw_cfg Hu Tao
2013-03-21  8:35 ` [Qemu-devel] [RFC][PATCH v15 6/6] pvpanic: pass configurable ioport to seabios Hu Tao
2013-03-21  9:09   ` Paolo Bonzini
2013-03-21  9:08 ` [Qemu-devel] [PATCH v15 1/2] add pvpanic device driver Hu Tao
2013-03-21  9:08 ` [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport Hu Tao
2013-03-21  9:11   ` Paolo Bonzini
2013-03-21  9:17     ` Hu Tao
2013-03-22  7:48       ` Gleb Natapov
2013-03-26  1:59         ` Hu Tao
2013-03-26  7:03           ` Paolo Bonzini
2013-03-26  7:24             ` Hu Tao
2013-03-26  7:53               ` Paolo Bonzini
2013-03-26  8:52                 ` [Qemu-devel] [PATCH v15.1] Add pvpanic device driver Hu Tao
2013-03-26  9:08                   ` Paolo Bonzini [this message]
2013-03-26  9:14                     ` [Qemu-devel] [PATCH v15.1 resend] " Hu Tao
2013-03-21  9:54   ` [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport Michael S. Tsirkin
2013-03-22  7:25     ` Hu Tao
2013-03-21 22:54   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2013-03-22  7:23     ` Hu Tao
2013-03-21  9:13 ` [Qemu-devel] [PATCH v15] pvpanic: pvpanic device driver Hu Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515165A7.4020801@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=kevin@koconnor.net \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).