From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKRR0-0006HK-W2 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:48:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKRQz-0006Jn-HQ for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:48:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKRQz-0006JZ-9b for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:48:53 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QAmqDp013231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 06:48:52 -0400 Message-ID: <51517D12.6020405@redhat.com> Date: Tue, 26 Mar 2013 11:48:50 +0100 From: Michal Novotny MIME-Version: 1.0 References: <385f3a1ca045e1b008de2b880eca1c8cce2a5231.1364229059.git.minovotn@redhat.com> <20130325143706.02313db2@redhat.com> In-Reply-To: <20130325143706.02313db2@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] New QMP command query-cpu-max and HMP command cpu_max List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 03/25/2013 07:37 PM, Luiz Capitulino wrote: > On Mon, 25 Mar 2013 17:31:33 +0100 > Michal Novotny wrote: > >> These commands return the maximum number of CPUs supported by the >> currently running emulator instance, as defined in its QEMUMachine >> struct. > I've applied this patch to the QMP tree, but with one change (see below). > >> Signed-off-by: Michal Novotny >> --- >> hmp-commands.hx | 14 ++++++++++++++ >> hmp.c | 8 ++++++++ >> hmp.h | 1 + >> qapi-schema.json | 11 +++++++++++ >> qmp-commands.hx | 22 ++++++++++++++++++++++ >> vl.c | 5 +++++ >> 6 files changed, 61 insertions(+) >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index df44906..c976459 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -690,6 +690,20 @@ Set the default CPU. >> ETEXI >> >> { >> + .name = "cpu_max", >> + .args_type = "", >> + .params = "", >> + .help = "Get maximum number of VCPUs supported by machine", >> + .mhandler.cmd = hmp_query_cpu_max, >> + }, >> + >> +STEXI >> +@item cpu_max >> +@findex cpu_max >> +Returns the number of CPUs supported by the machine being emulated. >> +ETEXI > What you really want is an info command, like 'info cpu_max'. As I didn't > spot this in my first review (looks like I'm still sleeping, although it's > afternoon) I've made that change myself and applied the patch to the qmp tree. > > Now, if you disagree I can drop it and we discuss the matter :) I'm fine with that :-) Michal -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org