From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKV1L-0008Va-5o for qemu-devel@nongnu.org; Tue, 26 Mar 2013 10:38:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKV1F-0004iL-Tx for qemu-devel@nongnu.org; Tue, 26 Mar 2013 10:38:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKV1F-0004iA-DN for qemu-devel@nongnu.org; Tue, 26 Mar 2013 10:38:33 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QEcWCj012434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 10:38:32 -0400 Message-ID: <5151B2E8.4080904@redhat.com> Date: Tue, 26 Mar 2013 08:38:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <514BC592.508@redhat.com> <1364225711-32566-1-git-send-email-imammedo@redhat.com> <20130325160959.4d5119d9@redhat.com> <5150B20C.5010406@redhat.com> <20130326144301.79fed257@nial.usersys.redhat.com> In-Reply-To: <20130326144301.79fed257@nial.usersys.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VOXSPDKQJUHEOBOIKNTW" Subject: Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VOXSPDKQJUHEOBOIKNTW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/26/2013 07:43 AM, Igor Mammedov wrote: >>> The alternative is to have cpu-set-online and later cpu-set-offline. = Quite >>> verbose, but doesn't have issues. > It looks like better as way to go. Later on we could keep them for > compatibility sake and map it to device_add/device_del commands when th= ey are > ready. >=20 > Considering all said above, would it be acceptable to replace cpu-set w= ith > "cpu_add id=3Dxx" command? cpu_add id=3Dxx from HMP, cpu-add from QMP is fine for getting things started; it still leaves room for a future 'cpu-set' batching command if batching turns out to be useful. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VOXSPDKQJUHEOBOIKNTW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUbLoAAoJEKeha0olJ0Nq6xYH+wdCHZPzai2+OFQZoIpH3/qQ 3tocHlIT8Rywn7c3riN6Cmw3EU9G28HlNBGfjIfXvPCniTGPDvacaJjZTMNgYHK+ V1aMuNnmClOiuMDXdnPGoUE4oWAO/fRAjnCwSOxpz9orphoHpii0mLPEhFfSuHzc 4x8XNpeAH/dCThjCDjXLTidjm1QUHkRPErLqSi71uvBYENRV7dt5yYxcUganFoYy tJFy1UUs9Gn//cMu28Aj0GR8h+8IHbIigX6Fr4mVKqQmN/h0fWDV55BzQymPT5qX QlSoz9aKc4dHv+R5ctzjlZms9VID5V1On74CbipQMpyZUsl8DzR+z/LxC+p6NE4= =XG4k -----END PGP SIGNATURE----- ------enig2VOXSPDKQJUHEOBOIKNTW--