From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWq6-0001iT-Af for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:35:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKWq4-0004BS-ST for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:35:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWq4-0004AM-JS for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:35:08 -0400 Message-ID: <5151CDE9.2030101@redhat.com> Date: Tue, 26 Mar 2013 10:33:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364314072-2474-1-git-send-email-stefanha@redhat.com> <1364314072-2474-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1364314072-2474-2-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2IBQDCRDLHKRGRBWOWMVP" Subject: Re: [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , david.pravec@nethost.cz, Juan Quintela , mprivozn@redhat.com, Corey Bryant , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IBQDCRDLHKRGRBWOWMVP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/26/2013 10:07 AM, Stefan Hajnoczi wrote: > There are several code paths in net_init_socket() depending on how the > socket is created: file descriptor passing, UDP multicast, TCP, or UDP.= > Some of these support both listen and connect. >=20 > Not all code paths set the socket to non-blocking. This patch addresse= s > the file descriptor passing and UDP cases which were missing > socket_set_nonblock(fd) calls. >=20 > I considered moving socket_set_nonblock(fd) to a central location but i= t > turns out the code paths are different enough to require non-blocking a= t > different places. Is it worth rearranging patch 3 first, so that you don't have to churn on these newly-added lines? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2IBQDCRDLHKRGRBWOWMVP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUc3pAAoJEKeha0olJ0NqNwUIAIHUmF8n98A96kkZ2dC6/MzJ 5o9JL49E+KfzlhxrYn8d+Ci+FUYl98lQAibwSVsxIeqqY8X2+mCPpwmMPFkiwwnl F7dvj6pMMTtS96lpHM/FvTm3MHwkC/oRuCIKcjF/uqDC9kINYAovKY140OPFYq5z QEKErvhK0gnQuVJfANm7y3AZUJwV0NlnDXoaEwFQrY41JS1o+xuanLZrhqzaj6OW tE4a9bKAE9Z8zTULITROXNKGKVLYaL0HoRfB5Gq06zQ7axERB1Vg7QjTrpzRGEIa S+y50s6IppRWJ0uWZT99gn7buhrGjSpxZunoZV0uXYKCQt/u+Tc9YQWG06R8wNA= =B17D -----END PGP SIGNATURE----- ------enig2IBQDCRDLHKRGRBWOWMVP--