From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKX41-0001QQ-Ry for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKX40-0000DG-2Q for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:49:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKX3z-0000Cw-NQ for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:49:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGnURj007276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 12:49:30 -0400 Message-ID: <5151D199.3010503@redhat.com> Date: Tue, 26 Mar 2013 10:49:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <5157d63de708d61a15baeefcca3be59a7e5a4d28.1363957855.git.phrdina@redhat.com> In-Reply-To: <5157d63de708d61a15baeefcca3be59a7e5a4d28.1363957855.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OGQGECGRSSLFVREJGUTO" Subject: Re: [Qemu-devel] [PATCH v2 03/12] savevm: add error parameter to qemu_savevm_state_begin() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OGQGECGRSSLFVREJGUTO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/22/2013 07:16 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 3 ++- > migration.c | 2 +- > savevm.c | 6 ++++-- > 3 files changed, 7 insertions(+), 4 deletions(-) > @@ -1807,9 +1808,10 @@ static int qemu_savevm_state(QEMUFile *f) > } > =20 > qemu_mutex_unlock_iothread(); > - qemu_savevm_state_begin(f, ¶ms); > + qemu_savevm_state_begin(f, ¶ms, NULL); > qemu_mutex_lock_iothread(); > =20 > + > while (qemu_file_get_error(f) =3D=3D 0) { Spurious line addition. Trivial enough that you can keep: Reviewed-by: Eric Blake if you fix it on the respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OGQGECGRSSLFVREJGUTO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUdGZAAoJEKeha0olJ0NqzZgIAIgcIhJ5SpcInWU4BwSOOlwD NYa/FGvF6CSjk13hg+CnyR/m/sDSFzPRTYopAiIAVugbKXTHeYH5J7Mw7QWUhOoK C+6VPDzJciY16WIqSES+kRrXolMCwWeNnY2NtFuBRqJopnJX2DmtFdBWC5iEEoyy DEiIAtWPyNRa55BrPS4KqNnoxENQRpbTnjc1Rrjjdj8c1zobDgWWWiFR4ll1twg/ V5NkslDnKi6dwaYHghx4OawAMogU/Pbqetqsw+XhP4ZTeRE5i4ZX/U1wicOiIia7 LSglL6BkI2Skf7gxBf2Y4pw6hYurPlNTZ+hELscvVzyQ3sw2UCnCf1D8LbfECpU= =yGGF -----END PGP SIGNATURE----- ------enig2OGQGECGRSSLFVREJGUTO--