From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKX90-0002Xj-HP for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:54:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKX8y-0002I7-UN for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:54:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKX8y-0002I3-L4 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:54:40 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGsdlc011803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 12:54:40 -0400 Message-ID: <5151D2CF.9000505@redhat.com> Date: Tue, 26 Mar 2013 10:54:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364316462-3383-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1364316462-3383-1-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HPDELGHIONMQEDKMDSMN" Subject: Re: [Qemu-devel] [PATCH 11/12 v3] qmp: add cpu-add qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HPDELGHIONMQEDKMDSMN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/26/2013 10:47 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v3: > * it appears that 'online/offline' in cpu-set are confusing people > with what command actually does and users might have to distinguish= > if 'offline' is not implemented by parsing error message. To simpli= fy > things replace cpu-set with cpu-add command to show more clear what= > command does and just add cpu-del when CPU remove is implemented. >=20 > v2: > * s/cpu_set/cpu-set/ > * qmp doc style fix > * use bool type instead of opencodding online/offline string > suggested-by: Eric Blake > --- > include/sysemu/sysemu.h | 2 ++ > qapi-schema.json | 11 +++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > qmp.c | 5 +++++ > stubs/Makefile.objs | 1 + > stubs/do_cpu_hot_add.c | 7 +++++++ > 6 files changed, 49 insertions(+) > create mode 100644 stubs/do_cpu_hot_add.c Reviewed-by: Eric Blake I didn't look at the rest of your series (I guess the remaining patches were only posted in v1?) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HPDELGHIONMQEDKMDSMN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUdLPAAoJEKeha0olJ0NqGVAH/3Wu8ZFPvgxQls4gJpQXcUre SlAIxg+n21Vp7Nh/Sq31TNmI7YaN93uHoVrdbyz1QpWPX3ZUTnJSAIp4l15lEzkc IU2WAFzI1BY5M+0T2w2GFCtMWlwDPBKBf+JSqjvCEdMoFXmU5Ibfxxm78SJT853V j31YyabQdqBR/AmNMP0R5qpjKK0Af07wFFck7rMD74xqrPvYauIoKTL7ZL3qgSWP 56QN492urfDTWMUzgOpEGChPDLnlv8rwj5yWOBlRlw89KFkhIXalnUttSNvbD2zF QAPbuUO3Povj+YyHfi+eQ7KSsINJlXBdqJl9AUGyIF9m+YaVM69L6e2H10Jp4fI= =HcKR -----END PGP SIGNATURE----- ------enig2HPDELGHIONMQEDKMDSMN--