From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57387)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UKXAB-0003nu-Vn
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:55:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UKXAA-0003EF-Gr
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:55:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UKXAA-0003Dz-7K
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:55:54 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGtrAs012274
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 26 Mar 2013 12:55:53 -0400
Message-ID: <5151D318.4000209@redhat.com>
Date: Tue, 26 Mar 2013 10:55:52 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <cover.1363957855.git.phrdina@redhat.com>
	<2807cb1036d5412c76b83d70aebfbbb27e24001d.1363957855.git.phrdina@redhat.com>
In-Reply-To: <2807cb1036d5412c76b83d70aebfbbb27e24001d.1363957855.git.phrdina@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="----enig2PEMJEALDASIFGGEWRHOJ"
Subject: Re: [Qemu-devel] [PATCH v2 04/12] savevm: add error parameter to
	qemu_savevm_state_iterate()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2PEMJEALDASIFGGEWRHOJ
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 03/22/2013 07:16 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  include/sysemu/sysemu.h | 2 +-
>  migration.c             | 2 +-
>  savevm.c                | 5 ++---
>  3 files changed, 4 insertions(+), 5 deletions(-)
>=20

Reviewed-by: Eric Blake <eblake@redhat.com>


> @@ -1811,9 +1811,8 @@ static int qemu_savevm_state(QEMUFile *f)
>      qemu_savevm_state_begin(f, &params, NULL);
>      qemu_mutex_lock_iothread();
> =20
> -
>      while (qemu_file_get_error(f) =3D=3D 0) {

Spurious whitespace change will go away when you fix 3/12 to not
introduce it in the first place.

> -        if (qemu_savevm_state_iterate(f) > 0) {
> +        if (qemu_savevm_state_iterate(f, NULL) > 0) {
>              break;
>          }
>      }
>=20

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


------enig2PEMJEALDASIFGGEWRHOJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJRUdMYAAoJEKeha0olJ0Nq2qsH/1suafwH1fXccEIt1f7xPYq3
0qd+2L1XOCsQkYG0lMLSJJCh+C7OLnJHgsrdcCFNHN7alrM06splKWPOwJmIr7Ej
rIE4UV8ME0bKUC0Yv72VMl9nqdSZriTDcBLRGxYrPT4IlMKWMfYMz4qXRBnbsCYn
aJqvs2DE4aZPmPHpsaEmGf4YSTWYmO8+iv5vr39sAX9uwR9kYnLI359JpsRRCjVZ
KaQP/IjHRHMA2iwBM6tMTMYtS3idWhzzCqjdVq+lnbFhpI/QQcI3pDNS1PF1cAT2
EFvFcPBbAAwTHpdt0xvf4JvMSFCKxZ93qtM5Oc4y7bjkiUgMYJn5DNH5kiyudIw=
=Hsg4
-----END PGP SIGNATURE-----

------enig2PEMJEALDASIFGGEWRHOJ--