From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZk4-0000MN-RP for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:41:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKZk3-00048j-JS for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:41:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZk3-00048b-AF for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:41:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QJf6KE023341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 15:41:06 -0400 Message-ID: <5151F9D1.1060304@redhat.com> Date: Tue, 26 Mar 2013 13:41:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <06467fc6c06628d760de026055644d339a65d7b5.1363957855.git.phrdina@redhat.com> In-Reply-To: <06467fc6c06628d760de026055644d339a65d7b5.1363957855.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DEFHAADVTDJNBRAOCTRJ" Subject: Re: [Qemu-devel] [PATCH v2 05/12] savevm: add error parameter to qemu_savevm_state_complete() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DEFHAADVTDJNBRAOCTRJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/22/2013 07:16 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 2 +- > migration.c | 2 +- > savevm.c | 5 +++-- > 3 files changed, 5 insertions(+), 4 deletions(-) >=20 > @@ -1734,6 +1734,7 @@ void qemu_savevm_state_complete(QEMUFile *f) > trace_savevm_section_end(se->section_id); > if (ret < 0) { > qemu_file_set_error(f, ret); > + error_setg(errp, "Failed to complete vmstate save."); I know I said I wouldn't keep mentioning error message conventions... therefore, I'm okay if you fix things, and add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DEFHAADVTDJNBRAOCTRJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUfnRAAoJEKeha0olJ0NqobAH/1tauoesqNBmQyXrNpQ+U6tK bC22cTNRs9Gu4xWuH+rFWA3ssmCvmbVgyJbr61RnjZpTuZPxBQ4YveTvlGzyp4zF iVHETJadLCtgWOZMivGd42TgMj2dNTegt7SZvfmvXoqmCSIg9xv7YJsWqcmz6xn6 guXunXRyFNqKBQkqnA1xY7BqnAK0uSKGn+Gcs7dn26FKIPO+0lw1R9NyUwoYwG+9 55maGC1czYQ9V6uc/Fu37hnTLhoywanBk1/Ghp2Y2j/t6xocYKiG6o9CtB/QDFbp ms0x+CKl+J2Rth3diB8ksjYNtQjrB4H5mIFrRLN5GRXrTyLqFdEEwk/p9BfrSQw= =1DPV -----END PGP SIGNATURE----- ------enig2DEFHAADVTDJNBRAOCTRJ--