qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits.
Date: Tue, 26 Mar 2013 14:08:56 -0700	[thread overview]
Message-ID: <51520E68.3050304@twiddle.net> (raw)
In-Reply-To: <20130326195028.GD22106@hall.aurel32.net>

On 03/26/2013 12:50 PM, Aurelien Jarno wrote:
>>> > > -# ifdef TARGET_MIPS
>>> > > +# if HOST_LONG_BITS == 64 \
>>> > > +     && (defined(TARGET_ABI_MIPSO32) || defined(TARGET_ABI_MIPSN32))
>>> > >  /* MIPS only supports 31 bits of virtual address space for user space */
>>> > > -unsigned long reserved_va = 0x77000000;
>>> > > -# else
>>> > > +unsigned long reserved_va = 0x7f000000;
>> > 
>> > Is it really wanted to change 0x77 into 0x7f? If yes, I think the
>> > commit log should explain why.
>> > 
> Ping?

As far as I could remember, that 0x77 was totally arbitrary too,
and so I thought I'd "fix" it.  I don't recall more, sorry.


r~

  reply	other threads:[~2013-03-26 21:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1360521050-29680-1-git-send-email-rth@twiddle.net>
     [not found] ` <1360521050-29680-8-git-send-email-rth@twiddle.net>
2013-03-05 11:18   ` [Qemu-devel] [PATCH 07/10] mips64-linux-user: Use MIPS64R2-generic as default cpu Aurelien Jarno
     [not found] ` <1360521050-29680-9-git-send-email-rth@twiddle.net>
2013-03-05 13:38   ` [Qemu-devel] [PATCH 08/10] target-mips: Fix check_cp1_64bitmode Aurelien Jarno
     [not found] ` <1360521050-29680-10-git-send-email-rth@twiddle.net>
2013-03-05 14:03   ` [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits Aurelien Jarno
2013-03-26 19:50     ` Aurelien Jarno
2013-03-26 21:08       ` Richard Henderson [this message]
2013-03-05 14:10 ` [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user Aurelien Jarno
     [not found] ` <1360521050-29680-7-git-send-email-rth@twiddle.net>
2013-06-09 17:46   ` [Qemu-devel] [PATCH] target-mips: 64-bit FPU for user-mode emulation Thomas Schwinge
2013-06-10 14:21     ` Maciej W. Rozycki
     [not found] <BA5E4206D1AE49DC9AB5F41EFE90E70F@domain.local>
2013-07-28  2:39 ` Petar Jovanovic
2013-08-05 14:15   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51520E68.3050304@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).