From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKb7I-0003TB-Pd for qemu-devel@nongnu.org; Tue, 26 Mar 2013 17:09:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKb7E-0006ie-HV for qemu-devel@nongnu.org; Tue, 26 Mar 2013 17:09:12 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:47673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKb7E-0006iP-DR for qemu-devel@nongnu.org; Tue, 26 Mar 2013 17:09:08 -0400 Received: by mail-oa0-f50.google.com with SMTP id n1so5295037oag.37 for ; Tue, 26 Mar 2013 14:09:07 -0700 (PDT) Sender: Richard Henderson Message-ID: <51520E68.3050304@twiddle.net> Date: Tue, 26 Mar 2013 14:08:56 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1360521050-29680-1-git-send-email-rth@twiddle.net> <1360521050-29680-10-git-send-email-rth@twiddle.net> <20130305140344.GG23040@ohm.aurel32.net> <20130326195028.GD22106@hall.aurel32.net> In-Reply-To: <20130326195028.GD22106@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org On 03/26/2013 12:50 PM, Aurelien Jarno wrote: >>> > > -# ifdef TARGET_MIPS >>> > > +# if HOST_LONG_BITS == 64 \ >>> > > + && (defined(TARGET_ABI_MIPSO32) || defined(TARGET_ABI_MIPSN32)) >>> > > /* MIPS only supports 31 bits of virtual address space for user space */ >>> > > -unsigned long reserved_va = 0x77000000; >>> > > -# else >>> > > +unsigned long reserved_va = 0x7f000000; >> > >> > Is it really wanted to change 0x77 into 0x7f? If yes, I think the >> > commit log should explain why. >> > > Ping? As far as I could remember, that 0x77 was totally arbitrary too, and so I thought I'd "fix" it. I don't recall more, sorry. r~