From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKbyz-00050w-4V for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:04:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKbyx-0003lB-Qc for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:04:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKbyx-0003l6-Ik for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:04:39 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QM4c5J027255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 18:04:38 -0400 Message-ID: <51521B75.80904@redhat.com> Date: Tue, 26 Mar 2013 16:04:37 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BHFFEBKAGAUEUDNLDJMF" Subject: Re: [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BHFFEBKAGAUEUDNLDJMF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/22/2013 07:16 AM, Pavel Hrdina wrote: > HMP command "savevm" now takes extra optional force parameter to specif= y whether > replace existing snapshot or not. >=20 > QMP command "vm-snapshot-save" has also extra optional force parameter = and > name parameter isn't optional anymore. Again, my question from 7/12 - why not rebase this series to implement QMP correctly from the getgo, and have this patch be JUST an HMP addition to expose the new QMP capability? >=20 > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 15 ++++++++------- > hmp.c | 3 ++- > qapi-schema.json | 7 +++++-- > qmp-commands.hx | 16 ++++++++++------ > savevm.c | 25 ++++++++++++++++--------- > 5 files changed, 41 insertions(+), 25 deletions(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 3c1cb05..bfe0645 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -307,18 +307,19 @@ ETEXI > =20 > { > .name =3D "savevm", > - .args_type =3D "name:s?", > - .params =3D "[tag|id]", > - .help =3D "save a VM snapshot. If no tag or id are provi= ded, a new snapshot is created", > + .args_type =3D "force:-f,name:s?", > + .params =3D "[-f] [tag|id]", > + .help =3D "save a VM snapshot. To replace existing snaps= hot use force flag.", Not an error message, so I'm not duplicating myself :) Prevailing convention seems to be omitting trailing '.' in .help messages= =2E > .mhandler.cmd =3D hmp_vm_snapshot_save, > }, > =20 > STEXI > -@item savevm [@var{tag}|@var{id}] > +@item savevm [@var{-f}] @var{tag}|@var{id} > @findex savevm > -Create a snapshot of the whole virtual machine. If @var{tag} is > -provided, it is used as human readable identifier. If there is already= > -a snapshot with the same @var{tag} or @var{id}, it is replaced. More i= nfo at > +Create a snapshot of the whole virtual machine. Parameter "name" is op= tional. > +If @var{tag} is provided, it is used as human readable identifier. If = there is > +already a snapshot with the same @var{tag} or @var{id}, @var{-f} flag = needs to > +be specified. More info at @ref{vm_snapshots}. > @ref{vm_snapshots}. @ref{vm_snapshots} now appears twice in the output. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BHFFEBKAGAUEUDNLDJMF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUht1AAoJEKeha0olJ0Nqv6MIAJnAjUlElGn116nOlko7VPh8 BCfl9M9f0NksozdG33XAI1P0UrzmMuNqEE6vOPnpE9zIk6LOkdEAB+rMLvNwsffj JxW0me2Z5hnM1gMndg1LUa8bsZbD9lJHF+KiBRpPpGMaMLF0oaocaOxQrSK755S6 OSk5wevgvMuyjYXMnMKsoxVArY7orKzwg22WhBVpXK2yfOOtKR1j1w9EY/i9/6dz q0w1FabwDSBrm5CdJcj2f6KPzV7/Z4FNxDbQXZpJqBXN61sT7iw99iAwlsMsriL5 ejmeizgN7zhAAod2KXLs3WDvXLIVG6JSBUWgGJVmx70at4+ywf3YH+oe7yft1D8= =4wny -----END PGP SIGNATURE----- ------enig2BHFFEBKAGAUEUDNLDJMF--