From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKc08-0006FN-G7 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:05:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKc04-0004Zw-7j for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:05:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKc03-0004Zg-If for qemu-devel@nongnu.org; Tue, 26 Mar 2013 18:05:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QM5lVN006383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 18:05:47 -0400 Message-ID: <51521BBA.2010500@redhat.com> Date: Tue, 26 Mar 2013 16:05:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <35a0a30a983efdecf0d79477789613d0a2dada57.1363957855.git.phrdina@redhat.com> In-Reply-To: <35a0a30a983efdecf0d79477789613d0a2dada57.1363957855.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AMDTASCIUVVHKUSKLMLU" Subject: Re: [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AMDTASCIUVVHKUSKLMLU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/22/2013 07:16 AM, Pavel Hrdina wrote: s/icrease/increase/ in the subject Some benchmark numbers in the commit message justifying your change would be nice. > Signed-off-by: Pavel Hrdina > --- > savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/savevm.c b/savevm.c > index 3e3d5f8..532c1be 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -112,7 +112,7 @@ void qemu_announce_self(void) > /***********************************************************/ > /* savevm/loadvm support */ > =20 > -#define IO_BUF_SIZE 32768 > +#define IO_BUF_SIZE 1 * 1024 * 1024 Improperly parenthesized; needs to be: #define IO_BUF_SIZE (1 * 1024 * 1024) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AMDTASCIUVVHKUSKLMLU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUhu6AAoJEKeha0olJ0NqmUEIAIKG0bmmjK8bgEnEBOUUrR0b 038MF9fyNulkT/iFCbVyY4gtPcm/U17mSULAcpePJgEprBGzwHv6y5KUzFEO+/xu /4SNNL+qLqD6ZnXBuf7Po9XZIGx787FJk7o3IrohvDenFat1m3ehJ49cKNJXAtKi zpRvzgF4OomMvPQ5Sc7OreCRtDfjtvZpqYjkmvHWBl6sxqgO65pWImrBR3w6joyG GTgjatQjwPnw5zQSovcs5eERtmJo9Q7mRfNzJ1k6LKWzZIHFD+Rbd+veHuJbKn+4 jqP3OvmENElh0KHZbAIKVatN2skcX5mxDE5EachGKEjgmzdOcqr2T124wA8w5AU= =hw+h -----END PGP SIGNATURE----- ------enig2AMDTASCIUVVHKUSKLMLU--