From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKkh7-0001SP-Ol for qemu-devel@nongnu.org; Wed, 27 Mar 2013 03:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKkh5-0007IP-Ro for qemu-devel@nongnu.org; Wed, 27 Mar 2013 03:22:49 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:51552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKkh5-0007IA-AH for qemu-devel@nongnu.org; Wed, 27 Mar 2013 03:22:47 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Mar 2013 17:15:39 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 1B1F62CE804A for ; Wed, 27 Mar 2013 18:22:42 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2R79eC147710360 for ; Wed, 27 Mar 2013 18:09:40 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2R7MeHm019653 for ; Wed, 27 Mar 2013 18:22:41 +1100 Message-ID: <51529E18.90807@linux.vnet.ibm.com> Date: Wed, 27 Mar 2013 15:22:00 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364310706-10851-1-git-send-email-aliguori@us.ibm.com> <1364310706-10851-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1364310706-10851-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] qtest: use synchronous I/O for char device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , qemu-devel@nongnu.org Reviewed-by: Wenchao Xia > Peter reported that rtc-test would periodically hang. It turns out > this was due to an EAGAIN occurring on qemu_chr_fe_write. > > Instead of heavily refactoring qtest, just use a synchronous version > of the write operation for qemu_chr_fe_write to address this problem. > > Reported-by: Peter Maydell > Signed-off-by: Anthony Liguori > --- > qtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qtest.c b/qtest.c > index 5e0e9ec..b03b68a 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -191,7 +191,7 @@ static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr, > len = vsnprintf(buffer, sizeof(buffer), fmt, ap); > va_end(ap); > > - qemu_chr_fe_write(chr, (uint8_t *)buffer, len); > + qemu_chr_fe_write_all(chr, (uint8_t *)buffer, len); > if (qtest_log_fp && qtest_opened) { > fprintf(qtest_log_fp, "%s", buffer); > } > -- Best Regards Wenchao Xia