From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKpIj-0006A2-7A for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:17:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKpId-0001Mg-Q4 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:17:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45516 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKpId-0001MR-F8 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:17:51 -0400 Message-ID: <5152E369.6070202@suse.de> Date: Wed, 27 Mar 2013 13:17:45 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-6-git-send-email-imammedo@redhat.com> <5152D180.8030800@redhat.com> <20130327131239.3de95ac3@nial.usersys.redhat.com> In-Reply-To: <20130327131239.3de95ac3@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, yang.z.zhang@intel.com, Paolo Bonzini , lcapitulino@redhat.com, rth@twiddle.net Am 27.03.2013 13:12, schrieb Igor Mammedov: > On Wed, 27 Mar 2013 12:01:20 +0100 > Paolo Bonzini wrote: >=20 >> Il 21/03/2013 15:28, Igor Mammedov ha scritto: >>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >>> index d03ff73..631bcd8 100644 >>> --- a/target-i386/cpu.c >>> +++ b/target-i386/cpu.c >>> @@ -2260,6 +2260,11 @@ out: >>> error_propagate(errp, local_err); >>> return; >>> } >>> + >>> + if (dev->hotplugged) { >>> + cpu_synchronize_post_init(env); >>> + resume_vcpu(CPU(cpu)); >>> + } >> >> I think the resume_vcpu should not be here, but in the superclass. >=20 > Then I should move following parts to superclass: >=20 > if (dev->hotplugged) { > cpu_synchronize_post_init(env); > resume_vcpu(CPU(cpu)); > } >=20 > because in case of KVM we should make sure that CPU in sane state befor= e > allowing CPU to become run-able. That's not possible until we change cpu_synchronize_post_init() argument to CPUState, which is somewhere down my TODO list. Currently I have mostly flushed my refactorings out, so if you wanted to dive into that, that would be appreciated. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg