From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKpMR-000821-Co for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:21:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKpMP-0002dw-TN for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:21:47 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:45061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKpMP-0002db-Lp for qemu-devel@nongnu.org; Wed, 27 Mar 2013 08:21:45 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Mar 2013 06:21:44 -0600 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id CBCB9C90025 for ; Wed, 27 Mar 2013 08:21:41 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2RCLfFe55050396 for ; Wed, 27 Mar 2013 08:21:41 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2RCLeel013168 for ; Wed, 27 Mar 2013 08:21:41 -0400 Message-ID: <5152E454.8060408@linux.vnet.ibm.com> Date: Wed, 27 Mar 2013 08:21:40 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1364315308.10914.5.camel@d941e-10> <5152E0CF.7050300@redhat.com> In-Reply-To: <5152E0CF.7050300@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: coreyb@linux.vnet.ibm.com, "qemu-devel@nongnu.org" , anthony@codemonkey.ws On 03/27/2013 08:06 AM, Paolo Bonzini wrote: > Il 26/03/2013 17:28, Stefan Berger ha scritto: >> QOM-ified the TPM support with much code borrowed from the rng implementation. >> >> What's missing may be that the tpm/tpm_passthrough.c be moved into backends/ . >> >> Signed-off-by: Stefan Berger >> >> --- >> v1->v2: >> - followed to git revision e769bdc26 >> >> --- >> backends/Makefile.objs | 2 >> backends/tpm.c | 154 ++++++++++++++++++++++++++++++++++++++++++++ >> include/qemu/tpm.h | 170 +++++++++++++++++++++++++++++++++++++++++++++++++ > I think these should be tpm_backend.[ch] (with the include file in > include/tpm). Can you rename the existing files with that name first? With the above file naming and directory placement I followed the pattern of backends/rng.c include/qemu/rng.h So are you planning on having them renamed and moved as well? My intention was to have tpm_passthrough moved into backends/. There's a file tpm/tpm_backend.c -- you want me to rename this one even though its located in a different directory? Since I am not running a git repository any move/rename would be a deletion of a file plus its addition. Stefan > Paolo >