qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] ppc: init_excp_7x0: fix hreset entry point.
@ 2011-02-15  8:56 Tristan Gingold
  0 siblings, 0 replies; 6+ messages in thread
From: Tristan Gingold @ 2011-02-15  8:56 UTC (permalink / raw)
  To: qemu-devel

From: gingold <gingold@020d506d-db78-4e55-b2a8-6c851f84c332>

According to the PowePC 750 user's manual, the vector offset for system reset
(both /HRESET and /SRESET) is 0x00100.

Signed-off-by: Tristan Gingold <gingold@adacore.com>
---
 target-ppc/translate_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5d856f5..907535e 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -2925,7 +2925,7 @@ static void init_excp_7x0 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
-- 
1.7.3.GIT

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point.
@ 2013-03-27 13:32 Fabien Chouteau
  2013-03-27 13:34 ` Alexander Graf
  0 siblings, 1 reply; 6+ messages in thread
From: Fabien Chouteau @ 2013-03-27 13:32 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-ppc, agraf

From: gingold <gingold@020d506d-db78-4e55-b2a8-6c851f84c332>

According to the PowePC 750 user's manual, the vector offset for system
reset (both /HRESET and /SRESET) is 0x00100.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
 target-ppc/translate_init.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 781170f..a5bae1e 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -2885,7 +2885,7 @@ static void init_excp_7x0 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2931,7 +2931,7 @@ static void init_excp_750cx (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2959,7 +2959,7 @@ static void init_excp_7x5 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2985,7 +2985,7 @@ static void init_excp_7400 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point.
  2013-03-27 13:32 [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point Fabien Chouteau
@ 2013-03-27 13:34 ` Alexander Graf
  2013-03-27 13:36   ` Fabien Chouteau
  0 siblings, 1 reply; 6+ messages in thread
From: Alexander Graf @ 2013-03-27 13:34 UTC (permalink / raw)
  To: Fabien Chouteau; +Cc: qemu-ppc, qemu-devel


On 27.03.2013, at 14:32, Fabien Chouteau wrote:

> From: gingold <gingold@020d506d-db78-4e55-b2a8-6c851f84c332>

What is this? :)


Alex

> 
> According to the PowePC 750 user's manual, the vector offset for system
> reset (both /HRESET and /SRESET) is 0x00100.
> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
> target-ppc/translate_init.c |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 781170f..a5bae1e 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -2885,7 +2885,7 @@ static void init_excp_7x0 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> @@ -2931,7 +2931,7 @@ static void init_excp_750cx (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> @@ -2959,7 +2959,7 @@ static void init_excp_7x5 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> @@ -2985,7 +2985,7 @@ static void init_excp_7400 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point.
  2013-03-27 13:34 ` Alexander Graf
@ 2013-03-27 13:36   ` Fabien Chouteau
  0 siblings, 0 replies; 6+ messages in thread
From: Fabien Chouteau @ 2013-03-27 13:36 UTC (permalink / raw)
  To: Alexander Graf; +Cc: qemu-ppc, qemu-devel

On 03/27/2013 02:34 PM, Alexander Graf wrote:
> 
> On 27.03.2013, at 14:32, Fabien Chouteau wrote:
> 
>> From: gingold <gingold@020d506d-db78-4e55-b2a8-6c851f84c332>
> 
> What is this? :)
> 

Oups :) Tristan Gingold is a colleague of mine. I'll fix this.

-- 
Fabien Chouteau

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point.
@ 2013-03-27 13:50 Fabien Chouteau
  2013-03-27 13:54 ` Alexander Graf
  0 siblings, 1 reply; 6+ messages in thread
From: Fabien Chouteau @ 2013-03-27 13:50 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-ppc, agraf

According to the PowePC 750 user's manual, the vector offset for system
reset (both /HRESET and /SRESET) is 0x00100.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
 target-ppc/translate_init.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 781170f..a5bae1e 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -2885,7 +2885,7 @@ static void init_excp_7x0 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2931,7 +2931,7 @@ static void init_excp_750cx (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2959,7 +2959,7 @@ static void init_excp_7x5 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
@@ -2985,7 +2985,7 @@ static void init_excp_7400 (CPUPPCState *env)
     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
     env->hreset_excp_prefix = 0x00000000UL;
     /* Hardware reset vector */
-    env->hreset_vector = 0xFFFFFFFCUL;
+    env->hreset_vector = 0xFFF00100UL;
 #endif
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point.
  2013-03-27 13:50 Fabien Chouteau
@ 2013-03-27 13:54 ` Alexander Graf
  0 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2013-03-27 13:54 UTC (permalink / raw)
  To: Fabien Chouteau; +Cc: qemu-ppc, qemu-devel


On 27.03.2013, at 14:50, Fabien Chouteau wrote:

> According to the PowePC 750 user's manual, the vector offset for system

PowerPC?

> reset (both /HRESET and /SRESET) is 0x00100.
> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
> target-ppc/translate_init.c |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 781170f..a5bae1e 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -2885,7 +2885,7 @@ static void init_excp_7x0 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;

As you properly explained above, the reset vector is 0x100 according to the spec. However, hreset_excp_prefix is 0x0. How do we end up getting to 0xfff00100 here?


Alex

> #endif
> }
> 
> @@ -2931,7 +2931,7 @@ static void init_excp_750cx (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> @@ -2959,7 +2959,7 @@ static void init_excp_7x5 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> @@ -2985,7 +2985,7 @@ static void init_excp_7400 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_THERM]    = 0x00001700;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0xFFF00100UL;
> #endif
> }
> 
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-03-27 13:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 13:32 [Qemu-devel] [PATCH] PPC: init_excp_7x0: fix hreset entry point Fabien Chouteau
2013-03-27 13:34 ` Alexander Graf
2013-03-27 13:36   ` Fabien Chouteau
  -- strict thread matches above, loose matches on Subject: below --
2013-03-27 13:50 Fabien Chouteau
2013-03-27 13:54 ` Alexander Graf
2011-02-15  8:56 [Qemu-devel] [PATCH] ppc: " Tristan Gingold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).