From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKrND-0006Bw-2r for qemu-devel@nongnu.org; Wed, 27 Mar 2013 10:30:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKrN8-0001qd-61 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 10:30:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51828 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKrN7-0001qL-TB for qemu-devel@nongnu.org; Wed, 27 Mar 2013 10:30:38 -0400 Message-ID: <51530286.0@suse.de> Date: Wed, 27 Mar 2013 15:30:30 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-6-git-send-email-imammedo@redhat.com> <5152D180.8030800@redhat.com> <20130327131239.3de95ac3@nial.usersys.redhat.com> <5152E369.6070202@suse.de> <20130327142752.416c3828@nial.usersys.redhat.com> In-Reply-To: <20130327142752.416c3828@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, yang.z.zhang@intel.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, Paolo Bonzini , lcapitulino@redhat.com, rth@twiddle.net Am 27.03.2013 14:27, schrieb Igor Mammedov: > On Wed, 27 Mar 2013 13:17:45 +0100 > Andreas F=E4rber wrote: >>> Then I should move following parts to superclass: >>> >>> if (dev->hotplugged) { >>> cpu_synchronize_post_init(env); >>> resume_vcpu(CPU(cpu)); >>> } >>> >>> because in case of KVM we should make sure that CPU in sane state bef= ore >>> allowing CPU to become run-able. >> >> That's not possible until we change cpu_synchronize_post_init() argume= nt >> to CPUState, which is somewhere down my TODO list. Currently I have >> mostly flushed my refactorings out, so if you wanted to dive into that= , >> that would be appreciated. :) >=20 > Would something like this be acceptable? > --- > From 15502168009b7b5ae2b46d854c461e5ad031cdc6 Mon Sep 17 00:00:00 2001 > From: Igor Mammedov > Date: Wed, 27 Mar 2013 14:21:20 +0100 > Subject: [PATCH] cpu: Pass CPUState to *cpu_synchronize_post*() >=20 > Signed-off-by: Igor Mammedov > --- > cpus.c | 4 ++-- > include/sysemu/kvm.h | 12 ++++++------ > kvm-all.c | 8 ++------ > kvm-stub.c | 4 ++-- > 4 files changed, 12 insertions(+), 16 deletions(-) Looks good so far, did you grep for further occurrences? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg