From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UKs2g-0000kN-Ek
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:13:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UKs2f-00030n-A8
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:13:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UKs2e-00030f-QV
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:13:32 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2RFDWal024312
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 27 Mar 2013 11:13:32 -0400
Message-ID: <51530D6A.3000408@redhat.com>
Date: Wed, 27 Mar 2013 16:16:58 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1364292483-16564-1-git-send-email-hdegoede@redhat.com>
	<1364292483-16564-8-git-send-email-hdegoede@redhat.com>
	<51519DA6.3070306@redhat.com> <5151A301.30503@redhat.com>
	<5151A78D.5010708@redhat.com> <5152FDA9.1090606@redhat.com>
	<51530900.7050103@redhat.com>
In-Reply-To: <51530900.7050103@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of
 avail_connections to qdev-properties-system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Hi,

On 03/27/2013 03:58 PM, Paolo Bonzini wrote:
> Il 27/03/2013 15:09, Hans de Goede ha scritto:
>> Hi,
>>
>> On 03/26/2013 02:50 PM, Paolo Bonzini wrote:
>>
>> <snip>
>>
>>>> 1) For most problematic devices, the proper fix would be to make them
>>>> use a chardev qdev property for there chardev usage, and then this
>>>> would be automatically fixed, agreed?
>>>
>>> At least on x86, all devices already use a chardev qdev property.
>>
>> Yes on x86 maybe, but a lot of the other serial-port emulations are
>> still using serial_hds directly, making proper avail_connections tracking
>> a pain.
>
> serial_hds is still passed to most devices via a chardev qdev property.

Most, yes but not all, which is why I wrote "using serial_hds *directly*",
anyways see the patch which I send a while back which tries to deal with
all the *direct* serial_hds users, as well as with the monitor, and some
code which does chardev creation completely on its own.

Regards,

Hans