From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKs9b-0000Dx-AM for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKs9Z-0006Eb-If for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:20:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKs9Z-0006ED-8k for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:20:41 -0400 Message-ID: <51530E2F.2040707@redhat.com> Date: Wed, 27 Mar 2013 16:20:15 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-6-git-send-email-imammedo@redhat.com> <5152D180.8030800@redhat.com> <20130327131239.3de95ac3@nial.usersys.redhat.com> <5152E369.6070202@suse.de> <20130327142752.416c3828@nial.usersys.redhat.com> <51530286.0@suse.de> <20130327161624.4a56613a@nial.usersys.redhat.com> In-Reply-To: <20130327161624.4a56613a@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, yang.z.zhang@intel.com, lcapitulino@redhat.com, =?ISO-8859-1?Q?Andreas_F=E4rber?= , rth@twiddle.net Il 27/03/2013 16:16, Igor Mammedov ha scritto: > yep, I re-factored every *cpu_synchronize_post*() call, > > but considering an intention to call cpu_synchronize_post_init() from > qom/cpu.c this patch won't work nice since it will pull with itself > kvm-stub.o to *-user target. > > Due to qom/cpu.c is built only once for both softmmu and *-user targets, I > consider to move cpu_synchronize_post_init() & cpu_synchronize_post_reset() > from include/sysemu/kvm.h into include/sysemu/cpus.h with definition moved > into cpus.c + stubs for cpu_synchronize_post_init() &resume_vcpu() in > libqemustub for *-user target. > Adding stubs to libqemustub could be avoided if resume_vcpu() and > cpu_synchronize_post_init() are called from x86_cpu_realizefn() > at the cost of some ifdeffenery in include/sysemu/cpus.h though. > > But moving resume_vcpu() & cpu_synchronize_post_init() into qom/cpu.c looks > like good candidate for being reused by other targets. > > Paolo, > would it be acceptable to add resume_vcpu() & cpu_synchronize_post_init() > stubs into libqemustub? Can you instead add all of kvm-stub.c? Paolo