From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsFB-0003y7-L8 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsFA-0008K2-5L for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:26:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsF9-0008Jp-T8 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:26:28 -0400 Message-ID: <51530F99.8010405@redhat.com> Date: Wed, 27 Mar 2013 16:26:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1364315308.10914.5.camel@d941e-10> <5152E0CF.7050300@redhat.com> <5152E454.8060408@linux.vnet.ibm.com> In-Reply-To: <5152E454.8060408@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: coreyb@linux.vnet.ibm.com, "qemu-devel@nongnu.org" , anthony@codemonkey.ws Il 27/03/2013 13:21, Stefan Berger ha scritto: > > With the above file naming and directory placement I followed the > pattern of > > backends/rng.c > include/qemu/rng.h > > So are you planning on having them renamed and moved as well? Uff, we're really bad at consistent naming. :) Given the above, I guess backends/tpm.c is fine. Then let's do the following: include/tpm/tpm.h -> include/sysemu/tpm.h include/qemu/rng.h -> include/backends/rng.h your new include -> include/backends/tpm.h > My intention was to have tpm_passthrough moved into backends/. I'm not sure that is the right thing to do since tpm_passthrough has dependencies on DeviceState. It is not a pure backend, and if I understand correctly it would likely not work with other TPM front-ends than tpm_tis.c > There's a file tpm/tpm_backend.c -- you want me to rename this one even > though its located in a different directory? tpm_backend.c and tpm_backend.h seem misnamed to begin with, so that would be a separate but welcome change. > Since I am not running a git repository any move/rename would be a > deletion of a file plus its addition. I don't understand. Paolo