From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Gerhard Wiesinger <lists@wiesinger.com>,
Yan Vugenfirer <yan@daynix.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Dmitry Fleytman <dmitry@daynix.com>
Subject: Re: [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation
Date: Wed, 27 Mar 2013 16:46:03 +0100 [thread overview]
Message-ID: <5153143B.3090507@redhat.com> (raw)
In-Reply-To: <AD90ADF2-D803-43B5-B50C-4E14E1868DE6@suse.de>
Il 27/03/2013 15:49, Alexander Graf ha scritto:
>> > +#if defined(HOST_WORDS_BIGENDIAN)
>> > +#define const_cpu_to_le64(x) bswap_64(x)
>> > +#define __BIG_ENDIAN_BITFIELD
> Ah, sorry, I replied to the wrong version.
>
> ARE YOU KIDDING ME? BIG ENDIAN BITFIELD? BITFIELDS ARE _IMPLEMENTATION SPECIFIC_!
>
> Can we please revert this whole patch set and send the authors back to school?
Can we please maintain a decent tone?
First, this file comes from Linux. __BIG_ENDIAN_BITFIELD is a Linux
#define. No doubt it is wrong to define it based on
HOST_WORDS_BIGENDIAN, it is better to use a configure check. But it's
not the reason why PPC compilation fails.
Second, you haven't said _how_ it breaks PPC compilation. Just
cut-and-paste from the compiler is enough. Ok, I can guess it but not
always.
Third, there is no need to revert the patch set. The const_cpu_to_le64
should simply be removed, since little-endian conversion is already done
in vmw_shmem_ld32.
Paolo
next prev parent reply other threads:[~2013-03-27 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 9:21 [Qemu-devel] [PATCH V14 0/5] VMXNET3 paravirtual NIC device implementation Dmitry Fleytman
2013-03-09 9:21 ` [Qemu-devel] [PATCH V14 1/5] Checksum-related utility functions Dmitry Fleytman
2013-03-09 9:21 ` [Qemu-devel] [PATCH V14 2/5] net: iovec checksum calculator Dmitry Fleytman
2013-03-09 9:21 ` [Qemu-devel] [PATCH V14 3/5] Common definitions for VMWARE devices Dmitry Fleytman
2013-03-09 9:21 ` [Qemu-devel] [PATCH V14 4/5] Packet abstraction for VMWARE network devices Dmitry Fleytman
2013-03-09 9:21 ` [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation Dmitry Fleytman
2013-03-27 14:49 ` Alexander Graf
2013-03-27 15:46 ` Paolo Bonzini [this message]
2013-03-27 16:06 ` Alexander Graf
2013-03-27 16:36 ` Dmitry Fleytman
2013-03-28 9:09 ` Stefan Hajnoczi
2013-03-12 9:38 ` [Qemu-devel] [PATCH V14 0/5] VMXNET3 paravirtual NIC " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5153143B.3090507@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=dmitry@daynix.com \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).