From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UKsYJ-0006nW-3E
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:46:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UKsYH-0007WI-Bk
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:46:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UKsYH-0007W9-4G
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:46:13 -0400
Message-ID: <5153143B.3090507@redhat.com>
Date: Wed, 27 Mar 2013 16:46:03 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1362820866-23426-1-git-send-email-dmitry@daynix.com>
	<1362820866-23426-6-git-send-email-dmitry@daynix.com>
	<AD90ADF2-D803-43B5-B50C-4E14E1868DE6@suse.de>
In-Reply-To: <AD90ADF2-D803-43B5-B50C-4E14E1868DE6@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Gerhard Wiesinger <lists@wiesinger.com>, Yan Vugenfirer <yan@daynix.com>, Anthony Liguori <anthony@codemonkey.ws>, Dmitry Fleytman <dmitry@daynix.com>

Il 27/03/2013 15:49, Alexander Graf ha scritto:
>> > +#if defined(HOST_WORDS_BIGENDIAN)
>> > +#define const_cpu_to_le64(x) bswap_64(x)
>> > +#define __BIG_ENDIAN_BITFIELD
> Ah, sorry, I replied to the wrong version.
> 
> ARE YOU KIDDING ME? BIG ENDIAN BITFIELD? BITFIELDS ARE _IMPLEMENTATION SPECIFIC_!
> 
> Can we please revert this whole patch set and send the authors back to school?

Can we please maintain a decent tone?

First, this file comes from Linux.  __BIG_ENDIAN_BITFIELD is a Linux
#define.  No doubt it is wrong to define it based on
HOST_WORDS_BIGENDIAN, it is better to use a configure check.  But it's
not the reason why PPC compilation fails.

Second, you haven't said _how_ it breaks PPC compilation.  Just
cut-and-paste from the compiler is enough.  Ok, I can guess it but not
always.

Third, there is no need to revert the patch set.  The const_cpu_to_le64
should simply be removed, since little-endian conversion is already done
in vmw_shmem_ld32.

Paolo