From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKtWT-0007qX-7a for qemu-devel@nongnu.org; Wed, 27 Mar 2013 12:48:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKtWR-00022n-TY for qemu-devel@nongnu.org; Wed, 27 Mar 2013 12:48:25 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:58621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKtWR-00022b-PK for qemu-devel@nongnu.org; Wed, 27 Mar 2013 12:48:23 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Mar 2013 12:48:22 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id C0A0FC9002A for ; Wed, 27 Mar 2013 12:48:19 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2RGkXHD346176 for ; Wed, 27 Mar 2013 12:46:33 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2RGkX5v031267 for ; Wed, 27 Mar 2013 12:46:33 -0400 Message-ID: <51532268.40102@linux.vnet.ibm.com> Date: Wed, 27 Mar 2013 12:46:32 -0400 From: Stefan Berger MIME-Version: 1.0 References: <5150C415.9030302@linux.vnet.ibm.com> <87ehf3nnja.fsf@codemonkey.ws> <5150CDA8.3020300@linux.vnet.ibm.com> <51530DA2.2030409@linux.vnet.ibm.com> <51530E4B.2010203@linux.vnet.ibm.com> <20130327155303.GB29523@redhat.com> <51531A51.3050709@linux.vnet.ibm.com> In-Reply-To: <51531A51.3050709@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] vNVRAM / blobstore design List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Schopp Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Kent E Yoder , Corey Bryant , Michael Roth , qemu-devel , Kenneth Goldman , Anthony Liguori On 03/27/2013 12:12 PM, Joel Schopp wrote: > >> Yea it's not hard to invent a random format each time we write something >> on disk. >> >> But I think ASN.1 BER will be useful to have in qemu anyway. E.g. it's a >> better format for migration than what we have now. Once we have it in >> tree re-using it seems cleaner than maintaining some per-TPM thing. >> > > The asn.1 patches that have been posted seem to be getting a cool > reception. If people think asn.1 is the way to go some more review > comments, acked-bys, reviewed-bys, or signed-off-bys would make that > more likely to happen. The patches have gone through several rounds > of review and come with a decent set of tests but still haven't been > merged. I think they are very mergable. Let me post another version that makes all the tests in test-visitor-serialize pass, including the ones using visit_optional. I also think they are mergeable, but we should discuss a few aspects around it. There are standards behind this that we may or may not need to implement as such. I am thinking of CER encoding for example that imposes restrictions on the size of primitive elements to be less than 1000 bytes (section 9.2) and need constructed encoding when bigger. We may be able to change this limit to PAGE_SIZE * n with n = ?. There may be other aspects. Stefan