From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKuNK-0001o2-RZ for qemu-devel@nongnu.org; Wed, 27 Mar 2013 13:43:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKuNJ-0006Y7-Fi for qemu-devel@nongnu.org; Wed, 27 Mar 2013 13:43:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKuNJ-0006Xz-7g for qemu-devel@nongnu.org; Wed, 27 Mar 2013 13:43:01 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2RHgxGs030835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Mar 2013 13:42:59 -0400 Message-ID: <51532FA1.8070200@redhat.com> Date: Wed, 27 Mar 2013 18:42:57 +0100 From: Pavel Hrdina MIME-Version: 1.0 References: <35a0a30a983efdecf0d79477789613d0a2dada57.1363957855.git.phrdina@redhat.com> <51521BBA.2010500@redhat.com> In-Reply-To: <51521BBA.2010500@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 26.3.2013 23:05, Eric Blake wrote: > On 03/22/2013 07:16 AM, Pavel Hrdina wrote: > > s/icrease/increase/ in the subject > > Some benchmark numbers in the commit message justifying your change > would be nice. > >> Signed-off-by: Pavel Hrdina >> --- >> savevm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/savevm.c b/savevm.c >> index 3e3d5f8..532c1be 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -112,7 +112,7 @@ void qemu_announce_self(void) >> /***********************************************************/ >> /* savevm/loadvm support */ >> >> -#define IO_BUF_SIZE 32768 >> +#define IO_BUF_SIZE 1 * 1024 * 1024 > > Improperly parenthesized; needs to be: > > #define IO_BUF_SIZE (1 * 1024 * 1024) > I'm testing it now and it seems that there is no speed improvement. I'll drop this patch from the series. Both values makes first snapshot (means that there is no snapshot at all) in about 30s. Second snapshots takes about 320s and third snapshot after restarting qemu process takes the same as second snapshot. Test enviroment is: guest: 2G ram 2 vcpus qcow2 disk image host: 12G ram 1cpu/4 core/8 threads ordinary 7200rpm/500G hdd