From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: coreyb@linux.vnet.ibm.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support
Date: Wed, 27 Mar 2013 14:00:35 -0400 [thread overview]
Message-ID: <515333C3.80200@linux.vnet.ibm.com> (raw)
In-Reply-To: <51530F99.8010405@redhat.com>
On 03/27/2013 11:26 AM, Paolo Bonzini wrote:
> Il 27/03/2013 13:21, Stefan Berger ha scritto:
>> With the above file naming and directory placement I followed the
>> pattern of
>>
>> backends/rng.c
>> include/qemu/rng.h
>>
>> So are you planning on having them renamed and moved as well?
> Uff, we're really bad at consistent naming. :)
>
> Given the above, I guess backends/tpm.c is fine. Then let's do the
> following:
>
> include/tpm/tpm.h -> include/sysemu/tpm.h
I will make this a separate patch.
> include/qemu/rng.h -> include/backends/rng.h
> your new include -> include/backends/tpm.h
Ok, I will repost the same patch with the path for the include file changed.
Stefan
prev parent reply other threads:[~2013-03-27 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:28 [Qemu-devel] [PATCH v2] QOM-ify the TPM support Stefan Berger
2013-03-27 12:06 ` Paolo Bonzini
2013-03-27 12:21 ` Stefan Berger
2013-03-27 15:26 ` Paolo Bonzini
2013-03-27 18:00 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515333C3.80200@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=coreyb@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).