From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKueR-00029m-P3 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKueQ-0004qK-Ez for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:00:43 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:57149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKueQ-0004q5-Bo for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:00:42 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Mar 2013 14:00:40 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 53D0CC9001E for ; Wed, 27 Mar 2013 14:00:37 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2RI0bva9961474 for ; Wed, 27 Mar 2013 14:00:37 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2RI0aK7018357 for ; Wed, 27 Mar 2013 14:00:36 -0400 Message-ID: <515333C3.80200@linux.vnet.ibm.com> Date: Wed, 27 Mar 2013 14:00:35 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1364315308.10914.5.camel@d941e-10> <5152E0CF.7050300@redhat.com> <5152E454.8060408@linux.vnet.ibm.com> <51530F99.8010405@redhat.com> In-Reply-To: <51530F99.8010405@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: coreyb@linux.vnet.ibm.com, "qemu-devel@nongnu.org" , anthony@codemonkey.ws On 03/27/2013 11:26 AM, Paolo Bonzini wrote: > Il 27/03/2013 13:21, Stefan Berger ha scritto: >> With the above file naming and directory placement I followed the >> pattern of >> >> backends/rng.c >> include/qemu/rng.h >> >> So are you planning on having them renamed and moved as well? > Uff, we're really bad at consistent naming. :) > > Given the above, I guess backends/tpm.c is fine. Then let's do the > following: > > include/tpm/tpm.h -> include/sysemu/tpm.h I will make this a separate patch. > include/qemu/rng.h -> include/backends/rng.h > your new include -> include/backends/tpm.h Ok, I will repost the same patch with the path for the include file changed. Stefan