From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwg6-0000db-L9 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:10:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKwg4-0002sL-9V for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:10:34 -0400 Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:50470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwg4-0002sD-51 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:10:32 -0400 Received: by mail-ob0-f181.google.com with SMTP id ni5so8427069obc.40 for ; Wed, 27 Mar 2013 13:10:31 -0700 (PDT) Sender: Richard Henderson Message-ID: <51535232.5010406@twiddle.net> Date: Wed, 27 Mar 2013 13:10:26 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> <1364324502-9124-4-git-send-email-aurelien@aurel32.net> In-Reply-To: <1364324502-9124-4-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] target-i386: SSE4.2: fix pcmpXstri instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > ffs1 returns the first bit set to one starting counting from the most > significant bit. > > pcmpXstri returns the most significant bit set to one, starting counting > from the least significant bit. > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I wonder if this ought not just be squashed with patch 10. It would have made it easier to review, actually. That said, Reviewed-by: Richard Henderson r~