From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UKx2a-0004IC-MV
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:33:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UKx2X-0003hU-Sz
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:33:48 -0400
Received: from mail-oa0-f44.google.com ([209.85.219.44]:57921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UKx2X-0003hM-Nb
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 16:33:45 -0400
Received: by mail-oa0-f44.google.com with SMTP id h1so9353851oag.3
	for <qemu-devel@nongnu.org>; Wed, 27 Mar 2013 13:33:45 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <515357A4.8000605@twiddle.net>
Date: Wed, 27 Mar 2013 13:33:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1364391272-1128-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1364391272-1128-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] compiler: fix warning with GCC 4.8.0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/27/2013 06:34 AM, Paolo Bonzini wrote:
> GCC 4.8.0 introduces a new warning:
> 
>     block/qcow2-snapshot.c: In function 'qcow2_write_snapshots’:
>     block/qcow2-snapshot.c:252:18: error: typedef 'qemu_build_bug_on__253'
>               locally defined but not used [-Werror=unused-local-typedefs]
>          QEMU_BUILD_BUG_ON(offsetof(QCowHeader, snapshots_offset) !=
>                   ^
>     cc1: all warnings being treated as errors
> 
> (Caret diagnostics aren't perfect yet with macros... :)) Work around it
> with __attribute__((unused)).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Richard Henderson <rth@twiddle.net>

Thanks, I've just been adding -Wno-unused-local-typedefs locally for a bit.


r~