From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKxwJ-0004xt-OT for qemu-devel@nongnu.org; Wed, 27 Mar 2013 17:31:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKxwH-0007vb-11 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 17:31:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKxwG-0007vP-O5 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 17:31:20 -0400 Message-ID: <51536520.8020700@redhat.com> Date: Wed, 27 Mar 2013 15:31:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363961953-13561-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363961953-13561-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1363961953-13561-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GHHTFWDUDVLNNMBQMGAF" Subject: Re: [Qemu-devel] [PATCH V10 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GHHTFWDUDVLNNMBQMGAF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This patch adds function bdrv_query_snapshot_info_list(), which will > retrieve snapshot info of an image in qmp object format. The implementa= tion > is based on the code moved from qemu-img.c with modification to fit mor= e > for qmp based block layer API. >=20 > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > block/qapi.c | 52 +++++++++++++++++++++++++++++++++++++-----= ------- > include/block/qapi.h | 4 ++- > qemu-img.c | 4 ++- > 3 files changed, 45 insertions(+), 15 deletions(-) > + default: > + error_setg(errp, "Can't list snapshots of device '%s': %s"= , > + dev, strerror(-sn_count)); This works (hence I didn't notice it before), but you might want to use: error_setg_errno(errp, -sn_count, "Can't list snapshots of device '%s'", dev); Either way, you can keep my Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GHHTFWDUDVLNNMBQMGAF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRU2UgAAoJEKeha0olJ0NqouMH/3lVFGXWUELTmZ6r9u4nZhqy 5ThwAuJMW1YpbcpmEnYMkjUKlWGNUzjjOHmIsw3M0pW8Q+FSEOJ1BOScPh44o8yL zq6p6LRmJIdz0war4gQa/CST7LvE6o+ARh0PVVHiCzIY5WvUD9tP1w2xEEONxcPV rs1g1fQXWuJ+Rqjs+lgnn24tcNTtCbIp0AY1OFAPCTkXZ5vh+/LC1yOhWVe9HiWH 4pqNN/GDKFnhiCJHf7QN/KbHN4Vfuo5whdPZ1/Riq+TPssJZJ9Ptm1NSNoTVJpPd Zvzi4FGtEixti8qgWKo6aBNnKGH2fZOXQze7ey9uddosGIKgAPF09c/WJpxWagA= =2fFX -----END PGP SIGNATURE----- ------enig2GHHTFWDUDVLNNMBQMGAF--