From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless preprocessor conditions
Date: Wed, 27 Mar 2013 17:54:31 -0700 [thread overview]
Message-ID: <515394C7.30504@twiddle.net> (raw)
In-Reply-To: <20130328001442.GB5000@ohm.aurel32.net>
On 2013-03-27 17:14, Aurelien Jarno wrote:
>> >+/* We only support generating code for 64-bit mode. */
>> >+#if TCG_TARGET_REG_BITS != 64
>> >+#error "unsupported code generation mode"
>> >+#endif
>> >+
> I don't know when the s390 support has been removed, but it has not been
> removed from the configure script at that time. It looks better to me
> doing so than adding the error message there.
>
Adjusting the configure script would be good (use the interpreter?),
but I think the error is good documentation.
r~
next prev parent reply other threads:[~2013-03-28 0:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 18:52 [Qemu-devel] [PATCH 00/12] tcg-s390 updates Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 01/12] tcg-s390: Fix movi Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 02/12] tcg-s390: Properly allocate a stack frame Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless preprocessor conditions Richard Henderson
2013-03-28 0:14 ` Aurelien Jarno
2013-03-28 0:54 ` Richard Henderson [this message]
2013-03-27 18:52 ` [Qemu-devel] [PATCH 04/12] tcg-s390: Implement add2/sub2 opcodes Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 05/12] tcg-s390: Implement mulu2_i64 opcode Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 06/12] tcg-s390: Implement movcond opcodes Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 07/12] tcg-s390: Implement deposit opcodes Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 08/12] tcg-s390: Remove constraint letters for and Richard Henderson
2013-03-28 15:03 ` Aurelien Jarno
2013-03-28 15:08 ` Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 09/12] tcg-s390: Use risbgz for andi Richard Henderson
2013-03-27 19:03 ` Paolo Bonzini
2013-03-27 19:27 ` Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 10/12] tcg-s390: Cleanup argument shuffling fixme in softmmu code Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 11/12] tcg-s390: Use load-address for addition Richard Henderson
2013-03-27 18:52 ` [Qemu-devel] [PATCH 12/12] tcg-s390: Use all 20 bits of the offset in tcg_out_mem Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515394C7.30504@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).