From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UL17A-0005FI-E8
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 20:54:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UL175-0002vj-VJ
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 20:54:48 -0400
Received: from mail-pa0-f41.google.com ([209.85.220.41]:37591)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UL175-0002uJ-OY
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 20:54:43 -0400
Received: by mail-pa0-f41.google.com with SMTP id kx1so1958067pab.0
	for <qemu-devel@nongnu.org>; Wed, 27 Mar 2013 17:54:43 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <515394C7.30504@twiddle.net>
Date: Wed, 27 Mar 2013 17:54:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1364410353-24728-1-git-send-email-rth@twiddle.net>
	<1364410353-24728-4-git-send-email-rth@twiddle.net>
	<20130328001442.GB5000@ohm.aurel32.net>
In-Reply-To: <20130328001442.GB5000@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless
 preprocessor conditions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, agraf@suse.de

On 2013-03-27 17:14, Aurelien Jarno wrote:
>> >+/* We only support generating code for 64-bit mode.  */
>> >+#if TCG_TARGET_REG_BITS != 64
>> >+#error "unsupported code generation mode"
>> >+#endif
>> >+
> I don't know when the s390 support has been removed, but it has not been
> removed from the configure script at that time. It looks better to me
> doing so than adding the error message there.
>

Adjusting the configure script would be good (use the interpreter?),
but I think the error is good documentation.


r~