From: Hans de Goede <hdegoede@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alberto Garcia <agarcia@igalia.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly
Date: Thu, 28 Mar 2013 12:42:04 +0100 [thread overview]
Message-ID: <51542C8C.6060108@redhat.com> (raw)
In-Reply-To: <1916380969.16382957.1364451537864.JavaMail.root@redhat.com>
Hi,
On 03/28/2013 07:18 AM, Paolo Bonzini wrote:
>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Alberto Garcia <agarcia@igalia.com>
>>
>> I don't think this is a show stopper, but this is a compatibility
>> breaker, no?
>>
>> We should be more up front about that and include release notes as
>> appropriate.
>
> Yes on all counts. I can work on the release notes.
Given that you requested this change, it indeed probably is best if
you did this :) Feel free to squash this into the patch if that is
preferred (and to make yourself the author of the patch in that case).
So how are we going to go about upstreaming these? Anthony will you
pick 1 + 2 up directly, and then 3 once the release notes are there,
or ... ?
Regards,
Hans
next prev parent reply other threads:[~2013-03-28 11:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 19:29 [Qemu-devel] [PATCH 0/3] chardev-frontends: Explicitly check, inc and dec avail_connections v2 Hans de Goede
2013-03-27 19:29 ` [Qemu-devel] [PATCH 1/3] qemu-char: Add qemu_chr_fe_claim / _release helper functions Hans de Goede
2013-03-27 19:29 ` [Qemu-devel] [PATCH 2/3] qemu-char: Call fe_claim / fe_release when not using qdev chr properties Hans de Goede
2013-03-27 19:29 ` [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly Hans de Goede
2013-03-27 21:18 ` Anthony Liguori
2013-03-28 6:18 ` Paolo Bonzini
2013-03-28 11:42 ` Hans de Goede [this message]
2013-03-28 11:39 ` Paolo Bonzini
2013-04-01 21:38 ` Alberto Garcia
2013-04-05 12:51 ` [Qemu-devel] [PATCH 0/3] chardev-frontends: Explicitly check, inc and dec avail_connections v2 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51542C8C.6060108@redhat.com \
--to=hdegoede@redhat.com \
--cc=agarcia@igalia.com \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).