From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43368)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1ULBAa-0006ch-30
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:39:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1ULBAX-0006Eo-Lx
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:39:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14058)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1ULBAX-0006Ek-AL
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:38:57 -0400
Message-ID: <51542C8C.6060108@redhat.com>
Date: Thu, 28 Mar 2013 12:42:04 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1916380969.16382957.1364451537864.JavaMail.root@redhat.com>
In-Reply-To: <1916380969.16382957.1364451537864.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev
 properties directly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alberto Garcia <agarcia@igalia.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Hi,

On 03/28/2013 07:18 AM, Paolo Bonzini wrote:
>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Alberto Garcia <agarcia@igalia.com>
>>
>> I don't think this is a show stopper, but this is a compatibility
>> breaker, no?
>>
>> We should be more up front about that and include release notes as
>> appropriate.
>
> Yes on all counts.  I can work on the release notes.

Given that you requested this change, it indeed probably is best if
you did this :)  Feel free to squash this into the patch if that is
preferred (and to make yourself the author of the patch in that case).

So how are we going to go about upstreaming these? Anthony will you
pick 1 + 2 up directly, and then 3 once the release notes are there,
or ... ?

Regards,

Hans