From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v15.2 4/6] pvpanic: add document of pvpanic
Date: Thu, 28 Mar 2013 06:16:32 -0600 [thread overview]
Message-ID: <515434A0.5090706@redhat.com> (raw)
In-Reply-To: <1364451363-25763-1-git-send-email-hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On 03/28/2013 12:16 AM, Hu Tao wrote:
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 docs/specs/pvpanic.txt
One typo remaining:
> +ACPI Interface
> +--------------
> +
> +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> +
> +RDPT: To determine whether guest panic notification is supported.
> +Rrguments: None
s/Rrguments/Arguments/
I think that can be fixed by whoever merges and sends the pull request,
without needing you to do a respin. With that fixed, you have:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-28 12:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 8:35 [Qemu-devel] [PATCH v15 0/6] Add pvpanic device to deal with guest panic event Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [PATCH v15 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [PATCH v15 2/6] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [PATCH v15 3/6] introduce a new qom device to deal with panicked event Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [PATCH v15 4/6] pvpanic: add document of pvpanic Hu Tao
2013-03-21 9:13 ` Paolo Bonzini
2013-03-22 7:15 ` Hu Tao
2013-03-26 3:03 ` [Qemu-devel] [PATCH v15.1 " Hu Tao
2013-03-26 9:21 ` Paolo Bonzini
2013-03-26 15:07 ` Eric Blake
2013-03-28 6:16 ` [Qemu-devel] [PATCH v15.2 " Hu Tao
2013-03-28 12:16 ` Eric Blake [this message]
2013-03-28 14:57 ` Paolo Bonzini
2013-03-29 7:15 ` Hu Tao
2013-03-29 7:12 ` Hu Tao
2013-03-22 1:59 ` [Qemu-devel] [PATCH v15 " Eric Blake
2013-03-22 7:15 ` Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [RFC][PATCH v15 5/6] pc_piix, pc_q35: export fw_cfg Hu Tao
2013-03-21 8:35 ` [Qemu-devel] [RFC][PATCH v15 6/6] pvpanic: pass configurable ioport to seabios Hu Tao
2013-03-21 9:09 ` Paolo Bonzini
2013-03-21 9:08 ` [Qemu-devel] [PATCH v15 1/2] add pvpanic device driver Hu Tao
2013-03-21 9:08 ` [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport Hu Tao
2013-03-21 9:11 ` Paolo Bonzini
2013-03-21 9:17 ` Hu Tao
2013-03-22 7:48 ` Gleb Natapov
2013-03-26 1:59 ` Hu Tao
2013-03-26 7:03 ` Paolo Bonzini
2013-03-26 7:24 ` Hu Tao
2013-03-26 7:53 ` Paolo Bonzini
2013-03-26 8:52 ` [Qemu-devel] [PATCH v15.1] Add pvpanic device driver Hu Tao
2013-03-26 9:08 ` Paolo Bonzini
2013-03-26 9:14 ` [Qemu-devel] [PATCH v15.1 resend] " Hu Tao
2013-03-21 9:54 ` [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport Michael S. Tsirkin
2013-03-22 7:25 ` Hu Tao
2013-03-21 22:54 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2013-03-22 7:23 ` Hu Tao
2013-03-21 9:13 ` [Qemu-devel] [PATCH v15] pvpanic: pvpanic device driver Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515434A0.5090706@redhat.com \
--to=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).